[FEAT]: nvim_set_hl should set "default" about barbecue.nvim HOT 7 CLOSED

This is the intended behavior, see theming.

from barbecue.nvim.

I have read the document. It doesn't mention why the default parameter is not used, though.

Just to be sure, I am talking about :h nvim_set_hl
• default: Don't override existing definition |:hi-default| in the following:

I notice that any particular group overrides theme.normal (possibly to allowing us to change background for all groups)

But none of them set the default parameter, even though they are supposed to be "default" values.

I can see that it has its own theming mechanism, like lualine. But unlike lualine, barbecue doesn't have theme = auto, or something similar.

Can you explain why this is the intended behaviour?

from barbecue.nvim.

I can see that it has its own theming mechanism, like lualine. But unlike lualine, barbecue doesn't have theme = auto, or something similar.

Yes, it does have! See the Configurations section on the readme.

from barbecue.nvim.

Apologies. Somehow missed that.

Still can't figure out why "default" is not set though. What does it break?

from barbecue.nvim.

barbecue_* highlights are meant to be generated on the fly according to the theme. So if the default option gets enabled, it'd be possible to end up with highlight values that weren't expected.

from barbecue.nvim.

Edit: on further inspection, I think this is fine.

Although, I wonder if we could get rid of the plugin load order issue.

NOTE: Make sure barbecue loads after your colorscheme.

from barbecue.nvim.

It's just good practice to load your colorscheme before any other plugin, from lazy.nvim readme:

NOTE: since start plugins can possibly change existing highlight groups, it's important to make sure that your main colorscheme is loaded first. To ensure this you can use the priority=1000 field. (see the examples)

from barbecue.nvim.