Giter VIP home page Giter VIP logo

Comments (5)

jheer avatar jheer commented on August 24, 2024 1

Thanks! You both convinced me to have Arquero throw an error when there are no shared columns. I've also updated the PR to (1) ensure proper handling of natural left, right, and full joins, and (2) suppress duplicated key column output.

The handling of full outer joins is a bit subtle. In SQL, natural full joins are not allowed. In dplyr, they are allowed but cause the "duplicate" key columns to be merged, using the value of whichever column is non-empty. I've followed the dplyr semantics here in Arquero when de-duplicating shared key columns in a full outer join.

from arquero.

jheer avatar jheer commented on August 24, 2024

Thanks for the suggestion! Rather than add a new method, I'm wondering if instead this should be the default behavior of join when given only a table as input. That sounds like it matches dplyr's behavior, as well as both your expectation and @juba's. Any thoughts?

from arquero.

jheer avatar jheer commented on August 24, 2024

I have a candidate PR for this issue here: #28

Rather than throw an error if there are no shared keys, the result is a Cartesian product (akin to cross), as this matches SQL natural join semantics.

from arquero.

bmschmidt avatar bmschmidt commented on August 24, 2024

I'd be happy to have this be default behavior for join, just thought this behavior might have been dictated by some standard.

That pull request works when 'on' is not specified, but it's also sensible to have this behavior if there is an on condition, as
sometimes happens with generic column names. E.g.:

  const t1 = aq.table({'state': ["MA", "NY"], 'count': [1, 4]})
  const t2 = aq.table({'state': ["MA", "NY"], 'count': [100, 400]})
  t1.join(t2, [['state'], ['state']])

could return the equivalent of

t1.join(t2, [['state'], ['state']], [aq.all(), aq.not("state")])

My fear about cross joins is that frequently when I'm being dumb, I try to join tables before properly aligning the column names and end up trying to allocate an ungodly number of rows in MySQL. dplyr supplies this message in the equivalent case: "Error: by must be supplied when x and y have no common variables. Use by = character()` to perform a cross-join."

from arquero.

juba avatar juba commented on August 24, 2024

I think this would be great, and I also agree with @bmschmidt caution about the potential danger of non explicitly asked for cartesian product : I already ended several times with a hanged session in R doing these sort of things, too.

from arquero.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.