Resolving NPM Vulnerabilities about storybook-design-token HOT 5 CLOSED

Hey, decent timing. I'm almost done with the v1 rewrite and will push it soonish.

from storybook-design-token.

Thanks for the feedback.

• colors can't be changed in design token stories (probably the intention), but do persist when going back to component stories. i could see how persisting values could be useful (e.g. when switching between different stories for the same component), however, it might be nice to have some control over that persistence. otherwise, it might be difficult to remember which values you changed (and where). perhaps solvable by some sort of reset button?

A global reset button sounds nice.

• (disclaimer: i'm on a mac) token sub tabs are difficult to scroll. also, just hovering over a tab triggers the scrollbar, which is a bit distracting. it's a tough problem to solve given the restraints of storybook addons, but important to solve nonetheless (imho).

Not really happy with it either. Really not sure how to solve this. The old way of showing all tokens on one screen had its problems, too.

• as mentioned above, i'm loving the design token section/stories. however, it seems that it's only for mdx? or does the same component work for CSF stories too?

I haven't tested it myself. But you should be able to use it with CSF as well. See: https://storybook.js.org/docs/react/writing-docs/docs-page#remixing-docspage-using-doc-blocks

• i've asked this before, but might as well ask again as you dev: will there be support for custom presenters? 😋

Definitely. Still trying to figure out the best way to configure and import external components as presenters.

from storybook-design-token.

Hello.

If you're interested, you could check out the v1 beta. It has some new features, simplified configuration and should get rid of the marked packages. However, it got some breaking changes and is not quite done yet.

yarn add storybook-design-token@next

Readme is here: https://github.com/UX-and-I/storybook-design-token/tree/v1

from storybook-design-token.

The upgrades look awesome!! I also linked our design team to the demo (they're aware that features are in progress) so I'm hoping they'll have some feedback as well because design isn't quite my forte. 😋

General Feedback:

• i really like the addition of the DESIGN TOKENS section in the nav. will make it much easier for designers to quickly access the tokens.
• i LOVE the previews! i can tell you're still figuring out how to preview some of the tokens, but what you have so far is fantastic! i particularly like the Animations/Easings previews. pretty slick! 😁
• colors can't be changed in design token stories (probably the intention), but do persist when going back to component stories. i could see how persisting values could be useful (e.g. when switching between different stories for the same component), however, it might be nice to have some control over that persistence. otherwise, it might be difficult to remember which values you changed (and where). perhaps solvable by some sort of reset button?
• (disclaimer: i'm on a mac) token sub tabs are difficult to scroll. also, just hovering over a tab triggers the scrollbar, which is a bit distracting. it's a tough problem to solve given the restraints of storybook addons, but important to solve nonetheless (imho).

Questions:

• as mentioned above, i'm loving the design token section/stories. however, it seems that it's only for mdx? or does the same component work for CSF stories too?
• have you considered any other options for rendering the token groups in the addons panel? it seems like it's unlikely to eliminate scrolling completely, but the horizontal scrolling of tabs feels worse than the vertical scrolling of the groups in 0.x. maybe a sliding door solution? i dunno, this one is tough! 😅
• i've asked this before, but might as well ask again as you dev: will there be support for custom presenters? 😋

All in all, I'm super psyched you're plowing forward on the project. It's hard to find good maintainers nowadays, so thank you!

from storybook-design-token.

Seeing as v1.1.0 is the current version, and I was able to spot-check that you are no longer referencing old v5.x storybook modules, I'm gonna close this issue. Thanks @Sqrrl !! 😋 👏

from storybook-design-token.