Comments (4)
@matthewchigira
Can you describe me in extended way what your expectations are? i do see that atm we treat (and serialize/export) PropTypes.date as "custom" type which later, on UXPin UI side is floating textarea which expect JSON as content
thoughts:
- I can assume that on merge-cli I should introduce new const/type -> date
- but what about UI on UXPin side? should we build new control (or use existing one if any exists; i can ask about existing one later)?
- any additional requirements like validation, maybe various date/datetime format support or anything about i didnt think yet?
I do need basics as i do not have experince with missing support for prop types in merge.
And i was not part of the team which put this task in the old backlog (fresh thought: maybe orginal backlog entry have additional info?)
from uxpin-merge-tools.
For all the TypeScript tickets, the aim is that the merge-cli is able to recognise and serialise every type available. Currently, if a customer has a prop in one of their components that was a date
, then it would not be available in UXPin.
but what about UI on UXPin side? should we build new control (or use existing one if any exists; i can ask about existing one later)?
My priority is more the serialisation, so I don't mind so much if we don't have a special date control in the UI. For now, it can be just a textfield or a floating text area. So long as the designer can interact with it and it update the component.
any additional requirements like validation, maybe various date/datetime format support or anything about i didnt think yet?
It might be a good idea to take a look at an existing TypeScript type (e.g. nunber
, string
) and see how it was implemented in the merge-cli. There are tests written and example components in the test directory for TypeScript features.
Hope that helps! Let me know if you have any more questions.
from uxpin-merge-tools.
#239
its worth to look on comment as UI can require some tweaking
from uxpin-merge-tools.
Closed by 239
from uxpin-merge-tools.
Related Issues (20)
- Pass underlying component from an Higher-Order component in spec mode
- Typescript export Problems HOT 2
- Easier debugging when a component fails to render
- Typescript Slow Experimental Mode
- Typescript Helper Functions not working
- Experimental Mode not working with Windows (and WSL) HOT 1
- Init Command HOT 4
- Stubbed Preset Generation HOT 2
- TypeScript: Serialize static default props of arrow function
- TypeScript: Serialize array of enums property
- TypeScript: Serialize Indexed signature property
- Typescript: Allow user to specify configuration
- TypeScript: Support component with non inlined export statement HOT 1
- Upgrade TypeScript setup and improve DX in `uxpin-merge-cli` HOT 1
- Colors package breaks CLI HOT 1
- Dependencies security audit HOT 2
- Improve UX and error handling when pushing libraries
- Fix delete command for branch names that include a slash `/` HOT 1
- Merge Documentation Overhaul
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uxpin-merge-tools.