Giter VIP home page Giter VIP logo

Comments (10)

oiffrig avatar oiffrig commented on August 9, 2024
>>> holidays.UK()[datetime.date.today()]
'Battle of the Boyne [Northern Ireland]'

However, it seems to concern only Northern Ireland.

from python-holidays.

thefuckinggasvols avatar thefuckinggasvols commented on August 9, 2024

Thanks for the explanation. Is there a "UK Bank Holiday" equivalent?

from python-holidays.

hugovk avatar hugovk commented on August 9, 2024

There's quite a few which are only for Northern Ireland or Scotland. I think all the England and Wales ones are also holidays in NI and Scotland.

https://www.gov.uk/bank-holidays

Perhaps the home nations should be added for the UK as "Provinces/States Available"?

https://github.com/ryanss/python-holidays#available-countries

from python-holidays.

dr-prodigy avatar dr-prodigy commented on August 9, 2024

From the code, it seems like that by design. Not really sure if it's correct or not anyway! What do you think?

from python-holidays.

coder6464 avatar coder6464 commented on August 9, 2024

Use holidays.England() for UK Bank Holidays. I've checked this against https://www.gov.uk/bank-holidays

from python-holidays.

hugovk avatar hugovk commented on August 9, 2024

This is a bug.

This particular holiday should only be in holidays.NorthernIreland().

from python-holidays.

hugovk avatar hugovk commented on August 9, 2024

Or rather, this is by design.

>>> import holidays
>>> for date, name in sorted(holidays.UK(years=2018).items()):
...     print(date, name)
...
2018-01-01 New Year's Day
2018-01-02 New Year Holiday [Scotland]
2018-03-30 Good Friday
2018-04-02 Easter Monday [England, Wales, Northern Ireland]
2018-05-07 May Day
2018-05-28 Spring Bank Holiday
2018-08-06 Summer Bank Holiday [Scotland]
2018-08-27 Late Summer Bank Holiday [England, Wales, Northern Ireland]
2018-11-30 St. Andrew's Day [Scotland]
2018-12-25 Christmas Day
2018-12-26 Boxing Day
>>>

See https://github.com/dr-prodigy/python-holidays/issues/40 for details.

If the holiday has square brackets, you'll need to check the country you're interested in is mentioned.

Or you can check holidays.England() or whichever ones you're interested in.

from python-holidays.

dr-prodigy avatar dr-prodigy commented on August 9, 2024

@hugovk : how should we manage this?

from python-holidays.

hugovk avatar hugovk commented on August 9, 2024

Well, at the moment it is working as designed, as detailed in #40.

If that's fine for everyone then this can be closed.

from python-holidays.

dr-prodigy avatar dr-prodigy commented on August 9, 2024

Okay, that's what I wanted to hear.. ;)
Thx mate!

from python-holidays.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.