Giter VIP home page Giter VIP logo

Comments (6)

vadymmarkov avatar vadymmarkov commented on June 5, 2024 1

I agree, we can start with errors. I will look into it 😉

from malibu.

onmyway133 avatar onmyway133 commented on June 5, 2024

@zwolsman Hi, Malibu deals with Promise, so you can use fail to catch error

.done({ boards in
    // Handle response data
  })
  .fail({ error in
    // Handle errors
  })
  .always({ _ in
    // Hide progress bar
  })

from malibu.

zwolsman avatar zwolsman commented on June 5, 2024

I saw that, but the problem is. if you have code like this

.validate(statusCodes: [200]).fail({err in print(err) })

The err will be Response status code \(statusCode) was unacceptable, you are not able to get the response body from the request..

from malibu.

vadymmarkov avatar vadymmarkov commented on June 5, 2024

@zwolsman Would it solve your problem if we extend error types with more parameters, like:

case unacceptableStatusCode(Int, Data, HTTPURLResponse)
case unacceptableContentType(String, Data, HTTPURLResponse)

from malibu.

zwolsman avatar zwolsman commented on June 5, 2024

@vadymmarkov I think that every error that throws (and there is data available) it should contain the data. Maybe a transformer too so you can map your data to your error object.

from malibu.

vadymmarkov avatar vadymmarkov commented on June 5, 2024

Version 6.1.0 with improved errors is out @zwolsman

from malibu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.