Updating valohai.yaml with valohai.prepare does not change the file name about valohai-utils HOT 5 CLOSED

(related to Zendesk ticket #1742)

from valohai-utils.

valohai.prepare does not set the command. The file name to execute is not an explicit part of the yaml step configuration, either: you can write whatever list of commands you want as the yaml command field. We do not and should never modify the existing command definition while executing yaml step.

To address this issue, we should instead change the default command to use a parameter to choose what file it will execute, and yaml step will set the filename it is parsing as a new implicit (Python wise, explicit yaml wise) parameter.

Existing steps will behave as before: the special filename parameter only gets created or updated if it already exists on the original. This is important for backwards compatibility.

from valohai-utils.

PRs in path dependency order; each step needs to be done prior to the next:

• valohai/valohai-yaml#115
• #119
• TODO: Upgrade Roi with new valohai-yaml and valohai-utils
• TODO: Upgrade CLI with new valohai-yaml and valohai-utils

Problem: Roi needs to support the new yaml and utils prior to CLI getting them in order to interpolate commands for executions, but CLI does not pin yaml and utils dependencies so users installing CLI will get too new yaml and utils that Roi doesn't support yet.

Solutions:

• Either Valohai-CLI needs to be released with a pinning to use valohai-utils and valohai-yaml of a specific version, and release an updated version once Roi has been released
• Or: Release yaml and utils as beta/private versions that CLI doesn't upgrade to, upgrade and release Roi with new yaml and utils, release yaml and utils to the general public
• Or: Make the new command-and-source-path behaviour optional on the CLI end, so it won't be used for new steps for users who don't need it (Needs CLI PR to introduce command flags to support this)

from valohai-utils.

testing with everything upgraded on local... (cli, roi)

from valohai-utils.

Also, while additional fields don't break older versions of yaml/utils/cli, using old versions will drop the source-path parameter and the step will break for executions due to referring to the special option that no longer exists.

However, this is easily noticed or reverted as all changes should be in git. This does involve some customer awareness though.

Nevermind, old versions will refuse to read a valohai.yaml with extra fields newly added to the schema.

We should probably add a valohai.yaml version field to the schema, allowing older versions of the CLI to notice that they're out of their depth modifying the file and provide a helpful error message.

from valohai-utils.