Update use of `connect` and `authenticate` to fix warnings about postgres-kit HOT 4 CLOSED

If I understand the issue correctly, PostgresNIO would also requires some changes, right now the only public connect function takes a PostgresConnection.Configuration where the Connection struct only accept host and port.
Those warnings come from the condition where you don't have a hostname, just a Unix domain socket. Will need PostgresNIO support before address them.

from postgres-kit.

Depends on Adding uds connection support #302

from postgres-kit.

After studying this issue I have come to a conclusion that additional changes will need to be made to the PostgresNIO package to fix this issue.

Currently, there are four ways to initialize a PostgresConfiguration in the PostgresKit:

• URL(String)
• URL(URL)
• Host:Port
• UnixDomianSocketPath.

The URL initializers parse the URL into the PostgresKit/PostgresConfiguration properties including the internal host and port fields.
The Host:Port initializer will also populate the internal host and port properties.
The UnixDomainSocketpath initializer does not populate the internal host and port properties. It sets them to 'nil'.

The PostgresNIO/PostgresConfiguration.Connection structure requires a hostname and port. They cannot be nil. Because the 'UnixDomainSocketPath" initializer does not provide host and port properties the current implementation of the PostgresKit/PostgresConnectionSource uses the deprecated connect method that includes a socket address instead of hostname and port. This in essence is the issue.

The address property in the PostgresKit/PostgresConfiguration structure is a 'public' property. I am not sure why it is public since it is defaulted to a closure during 'UnixSomainSockerPath' initialization. I guess it could be set after the fact but it doesn't make much sense. Note that it is also set during URL and Host:Port initialization but is never used for connection purposes.

As mentioned, PostgresNIO will have to changed so that the host property on the PostgresConnection.Configuration structure will accept a UnixdomainSocketPath. This is what is done on the libpq-C library. The host property can then be used to accept both a UnixDomainSockerpath or a host name.

from postgres-kit.

Completed in #241

from postgres-kit.