vis: move govis to library and rewrite it about go-mtree HOT 9 CLOSED

👍

from go-mtree.

After thinking some more about some aspects of all of this encoding. My current "fix" for unicode (#119) subtly broke \x__-style strings. Don't worry, it won't get hit by any of our encoding code. I'm working on a proper fix for it though.

from go-mtree.

I'm currently working on this in https://github.com/cyphar/govis.

from go-mtree.

from go-mtree.

Alright. Currently my Vis implementation has pretty solid integration and other tests. It also is unicode aware while also encoding unicode characters in a way that makes sure that legacy unvis implementations should "do the right thing" even though they don't understand unicode.

Namely this means that Vis will output ASCII and nothing else.

from go-mtree.

neat. Next step?

from go-mtree.

Well, there are two options:

1. We keep govis as a separate library, and add it as a dependency to go-mtree. The next step would be for me to tag govis and then rewrite the go-mtree code to import it.
2. We move govis into pkg/govis inside go-mtree so that there's no dependency issue. The next steps would be to move everything in and rewrite go-mtree to import it.

Which would you prefer?

from go-mtree.

from go-mtree.

yup, will do

from go-mtree.