`File` is not writing the trailing End tag about nbtlib HOT 4 CLOSED

I can confirm that this change also breaks schematic created with Litemapy for Litematica (see the Github mention above). Decompressing the file, adding a trailing null byte and re-compressing it works and allows the file to load both in game with Litematica and in NBTExplorer.

from nbtlib.

Oh right I didn't think about that, I was kind of in a rush sorry. I'm gonna try to go over all this in a few days. In the meantime I think the 2.x releases should be considered experimental and unstable.

from nbtlib.

I'd like to understand why File had this setting in the first place

because mojang write that...
the file is some thing like that iirc:

tagtypeid lenofname name data
and no end tag after "data"
just like a len=1 compound without end. eg:
{"":data

that is why the File class set end_tag = b""

from nbtlib.

I'd like to understand why File had this setting in the first place

because mojang write that... the file is some thing like that iirc:

tagtypeid lenofname name data and no end tag after "data" just like a len=1 compound without end. eg: {"":data

that is why the File class set end_tag = b""

That is not accurate, at least not for recent versions of Minecraft: level.dat, all map_*.dat files including idcounts.dat, and also chunk data, they all have a trailing NUL byte. NBT Explorer does not even show the file if it doesn't have the trailing byte, so likely Mojang does so from a long time.

from nbtlib.