Comments (2)
I'm currently being bitten by this problem... ;-)
Anyway, I reckon the approach more convenient for users would be for Websocket.establish_server
to automatically close the FD when the callback function terminates.
The question remains, however, whether to expect users to explicitly check within the callback function whether Frame.opcode
is Close
(and terminate if so), or if Websocket.establish_server
should do that automatically as well. I think the first approach may be more flexible, as long as the documentation states in very big letters that users should be diligent under penalty of leaking FDs...
from ocaml-websocket.
I think this is fixed now. Please reopen if not.
from ocaml-websocket.
Related Issues (20)
- Spurious Socket.t argument in Websocket_async.client_ez
- Unbound module Conduit_async_ssl in async/wscat.ml HOT 2
- Error: Unbound module Lwt_log_core HOT 1
- Usage with Mirage HOT 8
- Websocket_cohttp_lwt.upgrade_connection doesn't work with TLS connections HOT 5
- Release 2.13 on opam HOT 3
- cohttp_lwt: may be pass frames_out_fn into incoming_handler? HOT 1
- Make an opam release HOT 1
- Exception when client closes connection. Is this the expected behavior for async? HOT 2
- Lwt example fails with "Bad headers" when connecting from Firefox HOT 2
- Update to Conduit 3.0.0 HOT 2
- Closing client connections HOT 2
- New release HOT 3
- Expose a way to flush writes in `Websocket_lwt_unix` HOT 5
- Frame continuation ops code closes the websocket pipe reader prematurely. HOT 1
- End_of_file exception when doing `send` HOT 8
- websockets + react hangs on frequent messages HOT 1
- cohttp.1.0.0 support HOT 2
- lwt/websocket_cohttp_lwt.mli, line 24, characters 23-40: # Error: Unbound module Cohttp_lwt_body HOT 1
- How do I respend to client with subprotocol (Sec-WebSocket-Protocol). HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocaml-websocket.