Giter VIP home page Giter VIP logo

Comments (16)

1zun4 avatar 1zun4 commented on August 17, 2024 1

😩

from bldc.

Gabrielerusso avatar Gabrielerusso commented on August 17, 2024 1

Now it makes sense! thanks c:

Please report here, in my repo or in the Pull request if the fix actually works

from bldc.

Nikolai521 avatar Nikolai521 commented on August 17, 2024 1

are you using the scripts from my repo? what are you using (m365 or g30)?

My error, now it works!
image

i copied bad some lines 💀

from bldc.

Gabrielerusso avatar Gabrielerusso commented on August 17, 2024

I don't think there is any issue, the change was just to convert a value from 0 to 1 to simply cropping the value between 0 and 3.3, so you can't use the same code as before I think.

from bldc.

Nikolai521 avatar Nikolai521 commented on August 17, 2024

Probably, but now the resolution of these values are waaay to low

from bldc.

Gabrielerusso avatar Gabrielerusso commented on August 17, 2024

now the resolution of these values are waaay to low

I don't understand how after that change the resolution get lower. Post a code example that gives you a "lower resolution".
The picture you posted are exactly the value you used before, but scaled from 1 to 3.3, 0.5306V * 1/3.3 = 0.160788 that rounded is 0.1608, that means you are giving the wrong input to the override function. Before it was a value between 0 and 1, now is between 0 and 3.3 .

from bldc.

Nikolai521 avatar Nikolai521 commented on August 17, 2024

Actually is 1zuna code, you can find them on his repo https://github.com/m365fw/vesc_m365_dash/tree/6_05_adc

probably im going to record a video of the values, i cant explain well

from bldc.

Gabrielerusso avatar Gabrielerusso commented on August 17, 2024

Actually is 1zuna code

Again it's not a vesc issue but the code you posted wasn't updated, don't record any video. If i can i will mache a branch and fix the @1zun4 repo.

from bldc.

Nikolai521 avatar Nikolai521 commented on August 17, 2024

Yea sure, also i tried to contact with him and i got no response, so some friends asked me to do it in the vesc repo

from bldc.

Gabrielerusso avatar Gabrielerusso commented on August 17, 2024

Yea sure, also i tried to contact with him and i got no response, so some friends asked me to do it in the vesc repo

Gabrielerusso/vesc_m365_dash@589a7bf you can find here the fix.
When finished close the issue as it's not a VESC issue.

from bldc.

Nikolai521 avatar Nikolai521 commented on August 17, 2024

Now it makes sense! thanks c:

from bldc.

Nikolai521 avatar Nikolai521 commented on August 17, 2024

Now it makes sense! thanks c:

Please report here, in my repo or in the Pull request if the fix actually works

image

Now i get more rasonable values, but the script crashes if release the controls, with the voltage stuck on the last value
also i noticed it crashes just at 0.9974v (very near to 1)
image
image

edit: yep, it crashes just at 1, it works well under 0.9

from bldc.

Gabrielerusso avatar Gabrielerusso commented on August 17, 2024

Now it makes sense! thanks c:

Please report here, in my repo or in the Pull request if the fix actually works

image

Now i get more rasonable values, but the script crashes if release the controls, with the voltage stuck on the last value also i noticed it crashes just at 0.9974v (very near to 1) image image

edit: yep, it crashes just at 1, it works well under 0.9

are you using the scripts from my repo? what are you using (m365 or g30)?

from bldc.

Nikolai521 avatar Nikolai521 commented on August 17, 2024

are you using the scripts from my repo? what are you using (m365 or g30)?

Im using the yours, specifically the m365

from bldc.

Gabrielerusso avatar Gabrielerusso commented on August 17, 2024

i copied bad some lines 💀

When someone asks "Are you using the script from my repo" means the whole script, as for future reference don't do copy/paste mix-up or it becames impossible to track an issue.

Close the issue if it works.

from bldc.

Nikolai521 avatar Nikolai521 commented on August 17, 2024

Close the issue if it works.

Yup now works, actually it was my mouse, i moved it when i do the copy
Closing c:

from bldc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.