Giter VIP home page Giter VIP logo

Comments (9)

Pescovisck avatar Pescovisck commented on May 24, 2024 2

Since the day i installed this theme, i changed the vars to this black and orange theme (my favorite colors).
As the meme say:

I see this as an absolute win

from dark-whatsapp.

tinyCoder32 avatar tinyCoder32 commented on May 24, 2024 1

Hey @tinyCoder32, please keep to the scope of this and other issues.

I appreciate your work but I cannot test your extension for two reasons:

  1. I don't use proprietary extensions.
  2. I keep the extension list down to the minimum.

Hi @vednoc
I totally understand, i'm sorry.

Thanks for your efforts.

from dark-whatsapp.

vednoc avatar vednoc commented on May 24, 2024 1

I mean if we're talking userstyles wouldn't it be as simple as having a theme dropdown with different preset :root values?

It would be possible to have multiple :root presets, the problem is having too many of them -- the reason why theme switcher exists. Another problem that rises is, for the upcoming rewrite in stylus-lang, I don't know of a good way to accomplish that.

Assuming that dropdown had no given theme selected, defer to theme switcher or default theme (black and orange).

Default theme would be the case. Theme switcher will always override colors IF it's installed after the WhatsApp theme -- if necessary, that could be prevented in many different ways.

Having had a quick look at the theme switcher it looks like each individual option can be modified, but there are no full-suite named themes to choose from? Purely from a UX perspective, for users that just want something that "looks functional", that can be a bit overwhelming.

I agree, the UX sucks, but I don't expect majority of people to be changing colors all the time -- for me it's more of a set it and forget it type of thing. Not sure whether I should group the colors since this way people can mix and match colors from various color-schemes.

I think it's a good idea to align the defaults with your other projects.

It's gonna be alright. I really appreciate the input from the community and I'm fine with whatever is chosen. At the end of the day the theme switcher is doing an awesome job for me personally, and it's super easy to adjust colors for those that want to do it. 😄

from dark-whatsapp.

tinyCoder32 avatar tinyCoder32 commented on May 24, 2024

Hello again @vednoc , as promised before, people can customize your nice work with a nice chrome extension, would you mind testing it please?
https://chrome.google.com/webstore/detail/wa-web-plus/ekcgkejcjdcmonfpmnljobemcbpnkamh

from dark-whatsapp.

vednoc avatar vednoc commented on May 24, 2024

Hey @tinyCoder32, please keep to the scope of this and other issues.

I appreciate your work but I cannot test your extension for two reasons:

  1. I don't use proprietary extensions.
  2. I keep the extension list down to the minimum.

from dark-whatsapp.

richardcane avatar richardcane commented on May 24, 2024

I think it'd be a great idea to do this as some sort of theming switch if that's possible. I really like the original scheme with the blue, I think it's a little less harsh than black and orange.

from dark-whatsapp.

vednoc avatar vednoc commented on May 24, 2024

@richardcane: I think it'd be a great idea to do this as some sort of theming switch if that's possible.

It is, but it's a bit complicated to set up properly and I'd have to do it for every single theme I have. That is exactly why I made the theme switcher and it works great, though it does need more color-schemes. 😃

from dark-whatsapp.

richardcane avatar richardcane commented on May 24, 2024

I mean if we're talking userstyles wouldn't it be as simple as having a theme dropdown with different preset :root values? Assuming that dropdown had no given theme selected, defer to theme switcher or default theme (black and orange).

Having had a quick look at the theme switcher it looks like each individual option can be modified, but there are no full-suite named themes to choose from? Purely from a UX perspective, for users that just want something that "looks functional", that can be a bit overwhelming.

I think it's a good idea to align the defaults with your other projects. Perhaps keeping the current blue as an entire theme is a separate issue :D

from dark-whatsapp.

vednoc avatar vednoc commented on May 24, 2024

The dropdown menu with color presets is implemented in v2, and the old color-scheme will be kept as default because it had 60% of votes (or more at one point). Thanks to everyone that participated!

Closing this.

from dark-whatsapp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.