Clarification on Sidekiq patch about activejob-uniqueness HOT 1 OPEN

Hello @arizz96

thank you for this useful gem!

Thank you!

Can you please better explain how this patch works and why is it necessary?

The activejob-uniqueness is designed to be agnostic to ActiveJob adapters. Every adapter has its own queues implementation and jobs management. Deleting jobs does not automatically cleanup their locks.

But developers do expect this behavior, especially if they have used sidekiq + sidekiq-unique-jobs. The activejob-uniqueness has a Sidekiq patch to provide this experience. The patch patches internal Sidekiq API of jobs management in a way similar to sidekiq-unique-jobs approach. The patch is optional in order to give developers more control over locks cleanup.

why is it always calling ActiveJob::Uniqueness.unlock!, that delete locks using the wildcard?
I can understand that wildcard is useful when cleaning a queue, but why is it used also when a job (single job) death?

You are right, there is a probability that the queue might have a job with no arguments alongside with jobs with arguments. Deleting a single job with no arguments will unlock all jobs of this type.

Thank you for the report. This bug needs to be fixed.

from activejob-uniqueness.