Comments (13)
make a pr yourself? opensource 👍
from revisionable.
I would love to. I've just spent most of the morning trying to add a configuration file, but I'm just not able to get it to read. It just returns an empty array.
Here's the steps:
- Create config.php file with /workbench/venturecraft/revisionable/src/config/ with a simple
return array('test'=>true);
- Read it with
Config::get('package::test');
Any help would be greatly appreciated!
from revisionable.
Try Config::get('package::file.option'); ? http://laravel.com/docs/packages#package-configuration
from revisionable.
Thanks for the tip, but that does not seem to make a difference. It still returns an empty array.
from revisionable.
Like this? #28
from revisionable.
No, that still did not work for me. The Config::get() still returns an empty array. Could have it something to do with me having the package in the /workbench directory? Your code was exactly what I was trying to do though.
On a side note, I had to add a backslash to the \Config::get()
from revisionable.
That's indeed because of the naming, when you're having it in your workbench. If you think my code is what you want, the PR should be accepted by @VentureCraft himself, then you'll be able to use it.
from revisionable.
Thanks!
I would love to help improve this (and other) packages. What is the best way to contribute to an existing package then? Should I just do a normal composer install and modify the source from within the vendors folder?
from revisionable.
NP.
Yes, that's indeed the easiest way. Then you simply just fork the repo you wanna improve, and add the changes as well over there.
Good luck ;-)
from revisionable.
Take the user part out of the Model!
I use $this->updated_by to show the author of the last update, so you can use that value for the revisions table also.
edit:
if I use Revisionable I no longer need to save updated_by into my model...
from revisionable.
I've added support now for cartalyst in the lastest commit: 4d9dbb8
from revisionable.
great! but! Best practice would be not to use another system, especially
User related. let the app handle this, through a repo or something. Im
re-writing the whole thing, so expect a pull ;)
2014-02-20 0:33 GMT+02:00 Chris Duell [email protected]:
I've added support now for cartalyst in the lastest commit: 4d9dbb84d9dbb8
Reply to this email directly or view it on GitHubhttps://github.com//issues/27#issuecomment-35558312
.
from revisionable.
awesome, looking forward to it.... provided it does not use a service provider. As noted in previous comments, since a lot of people are already using this package in production, we can't introduce a mandatory service provider, otherwise it will break a lot of sites that don't have the service provider loaded.
That is, unless you have a way to make it fall back.
Looking forward to seeing what you come up with.
from revisionable.
Related Issues (20)
- identifiableName() doesnt work with model User HOT 1
- additional fields not beeing stored when Storing Creations HOT 2
- Supporting multiple auth HOT 1
- Nothing happens when I try to save instance from `Comment` model HOT 2
- Explicitly providing `user_id` to Revisionable HOT 1
- Revisionable not creating revision entries for belongsToMany relationships HOT 1
- Revisionable is largely abandonware – look elsewhere HOT 3
- More documentation around identifiableName() HOT 2
- so i created this fuction to return 'meta', anyone knows how to access [key] => date_achat / i want to display only the arrays where key == date_achat
- DateTime object to json serialization
- The article link in Readme.md is not working
- use in tables without integer primary key
- New Feature: Save changed and append custom data HOT 3
- Laravel 10 Support
- Is it a part instead of the whole? HOT 1
- Consider storing only attributes that have been changed and only the diff values HOT 1
- Please allow table name to be configurable HOT 2
- Invalid foreign key for SoftDelete returns unknown instead of the original id HOT 1
- Display revisions in Laravel Nova HOT 2
- Encrypted values not decrypting on read
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from revisionable.