Giter VIP home page Giter VIP logo

Comments (5)

guybedford avatar guybedford commented on May 17, 2024

Is this because the contents of the cwd of the build are not the same as the contents of the cwd of the runtime? If so, perhaps set the cwd option to point to the correct folder? The package.json should be emitted strictly speaking as that's what the asset emitter does.

We could possibly have a cwd: false option to disable cwd-based emissions.

from webpack-asset-relocator-loader.

chengcyber avatar chengcyber commented on May 17, 2024

Thanks you for the information about cwd: false. That is exactly what i want.

IMHO, process.cwd() should be not treated as static in most cases, while static is a feature. i.e. cwd: false as default.

from webpack-asset-relocator-loader.

guybedford avatar guybedford commented on May 17, 2024

I'm open to switching the default.

from webpack-asset-relocator-loader.

roryabraham avatar roryabraham commented on May 17, 2024

IMHO, process.cwd() should be not treated as static in most cases

I think I agree. I am using ncc in the context of CI/CD (Github Actions), and I need to be able to compile scripts locally and run them on various remote machines. But if I include a dependency that uses process.cwd, then the scripts I compile locally won't work on the remote runners, because they'll include filepaths on my local machine.

from webpack-asset-relocator-loader.

guybedford avatar guybedford commented on May 17, 2024

@roryabraham the safe route here is always to set the cwd option. A PR to improve the default would be welcome too.

from webpack-asset-relocator-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.