Duplicate packages when publishing about verdaccio-google-cloud HOT 11 CLOSED

Yeah, tested it with our own Google Cloud project, the duplication no longer occurs on the following cases:

• Unpublishing a version and republishing it
• Publishing a new version

Just to note, using npm publish

from verdaccio-google-cloud.

Just tested this and confirmed working using [email protected]. 👍

from verdaccio-google-cloud.

It might be, still experimental. I haven't had enough time to test it deeply.

from verdaccio-google-cloud.

Getting this issue as well, I'd love to work on this but I don't know where to begin

from verdaccio-google-cloud.

Hi @serratedserenade , I'd start reviewing the unit tests. I think the issue is within this plugin. Let me know if you need help.

from verdaccio-google-cloud.

I think the problem might be, the way I'm checking whether some entity exist is not well developed

from verdaccio-google-cloud.

Yeah I saw, I'm just randomly brute forcing the issue here haha, I do notice add is called without checking if the package exists yet so I think that's maybe that is it (?). The key/value pair just gets added with a new ID under Datastore.

I'm not 100% familiar with the working of the storage plugin or how verdaccio works internally yet but where would be the best place to write the fix or should I just modify add?

from verdaccio-google-cloud.

My attempt at the fix #8

from verdaccio-google-cloud.

Have you tried already this fix on live? @serratedserenade

from verdaccio-google-cloud.

published on [email protected]

from verdaccio-google-cloud.

Thanks for you help :)

from verdaccio-google-cloud.