Giter VIP home page Giter VIP logo

Comments (5)

gabrielStanovsky avatar gabrielStanovsky commented on June 26, 2024

Compare with PropS output for the same sentence

from okr.

kleinay avatar kleinay commented on June 26, 2024

@rachelvov also ran evaluation on V2 conversions, also got low entity mention extraction evaluation (~0.3).
I think we should try to split noun compound as much as possible. @gabrielStanovsky , is it a significant change of the props_wrapper? we should change and run evaluaion again as you suggested. @shanybar 's evaluation code is merged already I think.

from okr.

rachelvov avatar rachelvov commented on June 26, 2024

@gabrielStanovsky - how long do you estimate that the process of fixing this will take?
I need a decent V2 baseline for my thesis, and currently with node mention score of 0.3 it's really not good enough. I'm trying to decide whether to wait for the fix in the pipeline or to change the evaluation to more flexible (take partial match into account and etc).
Also please let me know if there's any way I can help with this.

from okr.

gabrielStanovsky avatar gabrielStanovsky commented on June 26, 2024

The problem is that I'm not sure what's the behaviour we want here.
For example, for the sentence "The summer school board council announced the new dates", we currently get this PropS parse
Which has this long entity mention summer school board council, as opposed to OKR which I assume will break it into 3 entities?

@kleinay and @rachelvov, what do you think the resulting PropSWrapper should look like?

I guess I can restore the dependency version, but I don't think that this would be very helpful, and will not improve the metrics according to V1 (but maybe in V2?)

@rachelvov, I think you can write in your thesis that a simple "noun baseline" achieves good results, but in general it deteriorates the performance for downstream tasks?

from okr.

rachelvov avatar rachelvov commented on June 26, 2024

I think for "summer school board council" V1 gold will be E1- "summer school", E2 - "board", E3 - council. you can't break summer school because it's not actually a school of/for summer, but "board council" is actually a council of boards. But this is indeed a hard case, most cases in the tweet are much easier.
Can we maybe use the baseline I made for the OKR paper? It was very simple (taking all Spacy NER mentions, and separate nouns and adjectives for everything that is not part of a NER mention) and had 85% F1 score.
@gabrielStanovsky not sure I understood what you meant in the last paragraph, let's talk tomorrow (in the lab or on phone).

from okr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.