Comments (6)
jodavies
commented on August 27, 2024
1
The freeze is due to a missing *in++; at token.c:370, but then it crashes instead.
from form.
jodavies
commented on August 27, 2024
So CodeGenerator does not have a case for TCONJUGATE, which only appears twice in the whole codebase (in token.c and its definition in ftypes.h). It seems, that no one has ever used this feature?
Since the manual says "The latest approach is that it is seen as obsolete. If possible, please avoid using it. " maybe we can just remove it entirely?
from form.
vermaseren
commented on August 27, 2024
As far as I know, nobody had been really using it.
It was created in version 1 in anticipation of a conjugation operation, but that never
materialised. Hence I must have forgotten about it when making the parser for version3
and later. For backward compatibility I never took out the conjugation #.
One can do either of two things:
1: take out this conjugation thing and see whether people complain.
2: fix up the parser.
Probably 2 is not too much work, although I have no idea whether there are still some
surprises.
… On 26 Apr 2024, at 12:39, jodavies ***@***.***> wrote:
So CodeGenerator does not have a case for TCONJUGATE, which only appears twice in the whole codebase (in token.c and its definition in ftypes.h). It seems, that no one has ever used this feature?
—
Reply to this email directly, view it on GitHub <#499 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJPCEWZYB3GIQUIZBXVIADY7IVH7AVCNFSM6AAAAABGSTKBQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGEZTKMBTGY>.
You are receiving this because you are subscribed to this thread.
from form.
tueda
commented on August 27, 2024
The manual also says
This property is only relevant, when the complex conjugation operator is used. This operator has not been implemented and currently there are no plans to do so.
I think we can just display a "not implemented" error (and that is much better than the crash/freeze).
from form.
jodavies
commented on August 27, 2024
That seems reasonable, just print the error and terminate. Do you want to make the PR @tueda ?
from form.
tueda
commented on August 27, 2024
@jodavies OK, I will create a PR for that.
from form.
Related Issues (20)
- Resolve Helgrind/DRD errors (i.e., multithreading issues) HOT 2
- building current master failure with docs / maybe a new tag/release? HOT 7
- Outdated Developer's reference manual
- Collect developer's tips HOT 1
- Valgrind reports memory leak due to FactArg HOT 4
- MakeInteger: No memory while allocating NumberMalloc HOT 7
- Bad error message for full SubSmallExtension HOT 1
- refactor: Warning function with format
- Tensors don't accept argument field wildcards anymore HOT 5
- ParFORM redefine bug with more than one expressions HOT 1
- Improved UTF-8 support HOT 11
- macOS-11 runner deprecation HOT 1
- Sorted function argument too long - Called from InFunction HOT 6
- Problem with Mac port HOT 2
- Zstd compression for sort files HOT 6
- Trying to open a nonexisting table doesn't generate an error HOT 14
- Encoding problem when opening a file HOT 2
- Pattern matching negative vectors sometimes drops the minus sign HOT 1
- Passing sets to procedures HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from form.