Origin.isValid() incorrectly rejects `chrome-extension` scheme about vertx-web HOT 5 CLOSED

I'll take a look, thanks for the report

from vertx-web.

@werdnum as a workaround, you can modify .addRelativeOrigin(".*") to .addRelativeOrigin("(https|chrome-extension)://.*")

from vertx-web.

There are different behaviors in the CorsHandler implementation:

• if all origins are accepted, the implementation check if the origin header is a valid Origin with Origin.isValid
• if a static origin is configured, its format is validated by the Origin constructor; then the origin header value is implicitly validated when comparing the strings with Origin.sameOrigin
• if a relative origin is configured, we just trust the pattern provided by the user

@pmlopes I believe we should update the code so that:

• CorsHandler checks if the origin header value is a valid origin, even when tested against a relative origin pattern
• Origin supports chrome-extensions

Sounds good to you?

from vertx-web.

@pmlopes ping :-)

from vertx-web.

Fixed by 69c27c0

from vertx-web.