Comments (5)
To support OAuth the Resource Server side of things should vertx-auth-service have an api added or extend AuthService to log a user in with just a bearer token? Or should we use the existing api somehow?
from vertx-web.
@pmlopes Do we postpone it to 3.2.0 ? ( I didn't follow the progress, so maybe it's fixed)
from vertx-web.
we postpone because @millross plan is to complete the implementation of vertx3 pac4j and then finish the fully async only OAuth support. (pac4j does way more stuff than just oauth but parts of its API are blocking so he is busy trying to convert some things to async and run other in a worker thread...)
from vertx-web.
Agree with this postponement. Just as an FYI Jérôme (pac4j) has an aspiration to make pac4j optionally non-blocking in future (by offering a non-blocking API and also a plugin client implementation for http requests based on the clients used by the various non-blocking implementations, ie we would offer a vert.x http implementation, for example, as part of the vert.x-pac4j implementation). Depending on what this looks like when we get cracking on it, this may offer a better solution than my vertx-oauth implementation.
I might also look at whether, if that's not viable straightforwardly, separating out some more pac4j stuff so that it can be used conveniently by my OAuth2 implementation, which means every time pac4j add support for a new OAuth2 provider, we can reuse it in the non-blocking implementation, so only the raw "OAuth2" workflow is implemented, and then uses Pac4j configuration for the rest of it. However, that's rather thinking aloud.
from vertx-web.
See https://github.com/vert-x3/vertx-auth/issues/39
from vertx-web.
Related Issues (20)
- Integrate WebClient with Service Resolver HOT 2
- WebClient does not use the server Address in RequestOptions
- It does not allow loading templates that are outside of the path. HOT 1
- `WebClient.close()` does not return a `Future` or wait for resources to be released HOT 4
- Possibility to close connection HOT 3
- Can't handle http2 errors in StaticHandler AsyncFile HOT 1
- oauth2 should not redirect (HTTP 302) XHR requests HOT 2
- HttpContext.fail() does not release the connection when invoked in SEND_REQUEST phase
- WebClient: NPE on misformatted Date or Expires header HOT 1
- absoluteURI is null when host header is missing HOT 2
- Issue with POST request hanging indefinitely in Vert.x Web HOT 3
- CSRF validation fails because CSRFHandler updates the session AFTER the session is already flushed HOT 1
- SockJS Event Bus Bridge does not keep web sessions alive for clustered session managers
- When upgrade vertx4, the path cannot support colon, and vertx 3 is ok HOT 1
- Use the new `OAuth2AuthorizationURL` in `OAuth2AuthHandler.extraParams`
- Reduce heavy atomic operations on RoutingContextImplBase HOT 1
- Rx Version of OAuth2AuthHandler Handler fails to add scopes HOT 2
- Vertx web randomly returns 404 error for certain POST requests even though for other similar requests it returns 200 HOT 2
- ChainAuthHandlerImpl#postAuthentication throws NPE HOT 1
- BodyHandler should not be added before the ProxyHandler HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vertx-web.