Add the ability to filter the metrics to expose about vespa_exporter HOT 7 OPEN

• @gjoranv

Sounds good to me. We do this for our internal metrics integration as well, so there is already syntax for it in services.xml:

<admin>            
    <metrics>
        <consumer id='e.g promotheus'>
            <metric id='some.metric'/>
            ...
        </consumer>
    </metrics>
<admin>            

I suggest that we

• Document this syntax in https://docs.vespa.ai/documentation/reference/services-admin.html
• Create a new config definition in Vespa which contains this information only (currently we only have it as part of a larger, internal config for our internal metrics integration).
• Expose that new config from the config model.
• Look it up from the Prometheus exporter using the config/v2 REST API of the config server to do what you need.

Gjøran, perhaps you could help with this?

from vespa_exporter.

Btw, do you want to be a committer to this repo dkurzaj? I think that makes sense.

from vespa_exporter.

That seems like a nice integration indeed!

Thank you, I would gladly become a committer. :)

In the mean time, to fit my needs, I have already implemented a first naive solution which reads a file containing the whitelisted metrics (one per line) and only expose them. Would you like me to make a PR with it to temporarily fix this issue or do you prefer that we wait for the changes you described ?

from vespa_exporter.

Thanks - I sent you an invite.

We try to avoid depending on local files so maybe it is better to wait for the config-backed solution, if you have a little bit of time to work on it.

from vespa_exporter.

Understood!

from vespa_exporter.

I did not really follow the new features of Vespa, but by reading the latest blog post (https://blog.vespa.ai/vespa-product-updates-september-2019-tensor/) it seems that this project will not be needed to monitor through Prometheus for the future versions of Vespa is it right?

from vespa_exporter.

I hope not. If there's something missing from the new integration, we should rather add it there. It mainly consists of two classes:
PrometheusHandler
and
PrometheusUtil

It's based on a PR from an external contributor. I haven't used Prometheus myself, so it would be great if you want to try it out.

from vespa_exporter.