Comments (8)
Ugh line endings again... Could you please provide this odd file so i can fix it once and for all?
from gulp-html-replace.
Sure,
but how should I do that? It seems, i cannot attach it here.
from gulp-html-replace.
Would splitting lines based on \n only (completely ignore \r) be the right approach here? If you do that the \r, if it's present, would just be part of the line. And you can handle any mixture of \n or \r\n lines. I don't think there is any need to actually test for \r\n.
from gulp-html-replace.
@ghost23 Maybe Dropbox, Google Drive worked pretty well in this comment too: #19 (comment) Any file sharing thing basically. Thank you.
@bmacnaughton It might work, but there may be some weird problems in rare cases. I better look at that file and run some tests before i do anything about it.
from gulp-html-replace.
That makes sense :)
https://www.dropbox.com/s/s5sej5grjr1fccv/line_endings-html.html?dl=0
from gulp-html-replace.
I think it works OK but you do have to make a decision on line 26 about what linefeed sequence to insert.
It wouldn't handle OLD Mac files with a \r line separator, but I don't think that really matters any longer.
from gulp-html-replace.
@bmacnaughton I'm using split by \n, this seems to be working ok, thanks for the idea. I think i better modify the code to not do "split" at all, but this is something for the future releases.
@ghost23, @charlescaron i've added your files to the "test" folder. I couldn't ask for a permission, there is no such thing as private messages on github, but if you're not ok with this (maybe those files are from some super-secret project or something) then please open an issue and i'll remove them.
from gulp-html-replace.
Thanks for the note. I think you're right - no split at all would be better but that's a bigger change. The history of line endings still makes life complicated.
from gulp-html-replace.
Related Issues (20)
- Incorrect string replacement more than one source HOT 1
- Incorrectly deleting build blocks HOT 2
- Support useref like blocks HOT 2
- newline under comment block inserted with keepBlockTags: true
- Concat and replace files HOT 3
- Comment Out a replace
- Check if input file is HTML? HOT 2
- newline added to block when 'keepUnassigned' and 'keepBlockTags' are true
- Add custom tag option HOT 4
- Add Closure to manipulate the data
- After `yarn add` none of dependencies is installed
- [Enhancement] Add support of one-string placeholders
- Allow for tasks with special characters in name
- Conditional Replacement
- Not keeping the order of my CSS ?
- Support for Jade/Pug files
- How to find only file name and replace without modify the entire path HOT 3
- resolvePaths on true and change root folder
- The path is not replaced
- Treats JS script like a url to JS script HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gulp-html-replace.