Giter VIP home page Giter VIP logo

Comments (10)

felipesanches avatar felipesanches commented on September 2, 2024

seems to be a mess... I think the end result needs to be GPL after mixing all of those licenses.

https://github.com/vgmrips/vgmplay/blob/f712603913050feca455dcd547f981dc1f2ebc9a/VGMPlay/licenses/List.txt

I agree that licensing should be stated more explicitly in the root of the repo.

from vgmplay-legacy.

chrisdonahue avatar chrisdonahue commented on September 2, 2024

Oh wow somehow I missed this. Thanks for filling me in! I agree that it would be nice if this could be aggregated at the root.

from vgmplay-legacy.

felipesanches avatar felipesanches commented on September 2, 2024

can you help us figure out the best way to do it?

from vgmplay-legacy.

superctr avatar superctr commented on September 2, 2024

Vgmplay is really one giant license violation, mixing GPL, non-GPL and proprietary licenses. I would not suggest using it for commercial purposes.

from vgmplay-legacy.

felipesanches avatar felipesanches commented on September 2, 2024

Beware that a licensing violation is still a violation even if not used with commercial purposes.

I would like to see such hypothetical violation fixed, instead of worked around.

from vgmplay-legacy.

superctr avatar superctr commented on September 2, 2024

Yes but doing so will either require a lot of work to replace the violating code or removing functionality. And much of the focus is now on libvgm anyway.

from vgmplay-legacy.

leycec avatar leycec commented on September 2, 2024

In Gentoo land, our working assumption has been that VGMPlay's bundling of multiple GPL 2-licensed dependencies effectively mandates that VGMPlay itself be GPL 2-licensed. Of course, there are confounding factors:

  • The license of three bundled dependencies (i.e., Ootake, MEKA, and in_wsr) is literally unknown.
  • Non-GPL dependencies are not necessarily compatible with the GPL 2 – but usually are, thankfully.
  • Nobody cares, because VGMPlay will either:
    • Be rewritten from the ground up to use libvgm, at which point most or all of this encumbered code will "be disappeared."
    • Go away entirely in favour of more mature alternatives (e.g., libvgm-based mpd plugin).
  • The legality of vgmrips.net itself is dubious at best. Fortunately, none of the relevant copyright holders (e.g., Sega) appear to particularly care – presumably because they're sufficiently divorced from reality that they fail to realize what an absolute goldmine of 80's synthwave nostalgia they're lazily hoarding.

It is sad. It is life. </collective_shrug>

from vgmplay-legacy.

superctr avatar superctr commented on September 2, 2024

Probably the biggest license violation currently in vgmplay would be most of the sound chip emulators that still fall under the old MAME license, which explicitly prohibits commercial use and is incompatible with the GPLv2. This code was rebased to the latest MAME version (which is either GPLv2 or BSD 3 clause) in libvgm.

from vgmplay-legacy.

ValleyBell avatar ValleyBell commented on September 2, 2024

I'm afraid libvgm still contains the sound cores from Ootake and in_wsr and this won't change anytime soon.
I need to replace the POKEY emulator someday though. It's the only one that still has the old MAME license.

libvgm won't use sound cores from MEKA at least. VGMPlay uses one of its cores for playing YM2413 VGMs on AdLib/Sound Blaster cards, but that's not something I plan to add to libvgm.

The biggest copyright violation in the whole project is PortTalk anyway, which is used for I/O port access on Windows NT/2000/XP.

from vgmplay-legacy.

superctr avatar superctr commented on September 2, 2024

Ootake's author can be contacted though the email address in the readme file. I would suggest doing so and ask if it is OK to distribute the sound code under the GPL.

in_wsr code comes from Oswan, for which I could not find a license or even the author's email address.

Porttalk I wouldn't worry about as it can easily be removed and I don't think the original author cares. His website is here anyway.

from vgmplay-legacy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.