Comments (4)
Would you please propose a patch? I support changing this.
On Jun 8, 2015 12:17 PM, "Markus Elfring" [email protected] wrote:
I find that include guards like "INDEX_H
https://github.com/ekg/vg/blob/4bbbd251aae0e753e6e326d14ea6c8b11be9de7f/index.hpp#L1"
and "PATH_H
https://github.com/ekg/vg/blob/0f4e94613213e983ef3e030321efd20f5036b3e1/path.hpp#L1"
are too short for the safe reuse of your header files (when they belong to
an application programming interface).—
Reply to this email directly or view it on GitHub
#42.
from vg.
Things should move to VG_INDEX_H
and so on. No?
from vg.
How do you think about to make include guards unique by appending a kind of UUID?
from vg.
I think that'd be fine, but if I implement the patch I'll do the simplest
thing and prefix VG on everything.
On Wed, Oct 7, 2015 at 5:56 PM, Markus Elfring [email protected]
wrote:
How do you think about to make include guards
https://en.wikipedia.org/wiki/Include_guard#Difficulties unique by
appending a kind of UUID
https://en.wikipedia.org/wiki/Universally_unique_identifier?—
Reply to this email directly or view it on GitHub
#42 (comment).
from vg.
Related Issues (20)
- GAF file empty with vg giraffe HOT 3
- Low-complexity pruning is slow in surjection
- Turn off surjection anchor limit by default
- Bump necessary magic numbers for long-read index types HOT 1
- vg autoindex --workflow mpmap HOT 1
- GAF nodes do not correspond to VCF nodes HOT 3
- Fastq analysis in euka HOT 2
- Protobuf errors mapping HOT 4
- vg augment crashes in combination with giraffe .gam outputs HOT 5
- when i do the code :vg stats -a var1.gam > var1.stats ,show me a bug HOT 2
- vg surject and pack fail on GraphAligner produced .gam HOT 4
- About the usage of vg deconstruct HOT 5
- Right method to annotate genes on pangenome graph HOT 1
- vg call report missing allele HOT 2
- vg call error HOT 2
- How do different methods affect precision? HOT 4
- Giraffe alignment is very slow and produces warning[vg::Watchdog] messages unless rescue is disabled HOT 12
- Giraffe needs to better deal with systems where multiple processes opening the distance index causes slowdowns
- Any option like BWA MEM '-C'?
- vg convert failes while converting gbz to xg with signal 6 error HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vg.