examples/custom-entity-type.js is broken about data-point HOT 2 CLOSED

This is because the helpers are being assigned directly on data-point and not in a helpers object on data-point.

I have 2 workable solutions, with one changing the exported data-point library.

Changing just the example with the following line will work: const Helpers = DataPoint. This solution seems wrong though, and conflicts with the example in the README here: https://github.com/ViacomInc/data-point/tree/0f84eafbe6b5d7f1df6cdd40d9a9e7cc0746a164/packages/data-point#adding-new-entity-types

The other solution is to modify the export in ~/packages/data-point/lib/index.js to put the helpers as a key on the exported object:

module.exports = Object.assign({}, require('./core'), { helpers: require('./helpers') })

This solution seems more correct but changes the API surface of data-point, so I'd like to know it's the correct solution before submitting a PR.

If either seems correct I can push a PR. Thanks!

from data-point.

Lets do changing the README and the example to use DataPoint's Object.

thanks for looking into this one!

from data-point.