Giter VIP home page Giter VIP logo

Comments (4)

vic avatar vic commented on May 10, 2024

Hey @lasseebert,

Definitely your use case seems valid to me, there should be a way to determine if some value was given on the request or completely missed. And as you mention I think the behaviour of to_map has to change, having nil values only if the user explicitly sent nil for that field or if the developer specified a default nil value for it. Please go ahead implementing it.

I've just added you as collaborator so you can directly merge things or send PR if you want some code review. Also merged ecto-2.x branch into master as I think we'll be adding more features on it and ecto-1.x branch will be kept behind.

Thanks again! :)

from params.

vic avatar vic commented on May 10, 2024

Oh, just to make it clear, I don't think we need a separate function besides to_map, so feel free to change it as you said.

from params.

vic avatar vic commented on May 10, 2024

We should update the documentation after this, IIRC it still mentions the old changes function. And we should mention the new behaviour of to_map and how it contrasts with data.

from params.

lasseebert avatar lasseebert commented on May 10, 2024

Thanks for making me a collaborator :)
I'll make the changes to to_map as discussed above.

from params.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.