Comments (4)
vitoziv
commented on June 5, 2024
1
I add a demo to show how to support HDR video, you can pull the latest code.
41c7870#diff-2dc4dc28f7aa306658725e96363ac9a93d6e8642d3435f0b5a15407b463ed796R128
HDR could be supported by subclass VideoCompositor
from cabbage.
m-at-drigmo
commented on June 5, 2024
Upon further digging, this appears to be HDR related issue.
The original is an HDR video, and it looks like the exported video did not preserve the HDR format.
Per Apple's WWDC sessions for exporting HDR, AVAssetExportSession will preserve HDR without extra code if default compositor is used (and the chosen preset is set to one of the AVAssetExportPresetHEVC* options).
When using custom compositor though (which is the case for Cabbage), it must be updated to be HDR aware.
I have tried rewriting the code above to use AVFoundation APIs directly, the video is exported correctly when HEVC preset is used.
from cabbage.
huanglins
commented on June 5, 2024
预览正常，导出存在偏色，我这边测试的视频是偏红😭
from cabbage.
Related Issues (20)
- Player add blur background HOT 6
- Use Kingfisher to report an error
- About the text overlay, edit, drag and drop, zoom. HOT 1
- CIImage Memory leak HOT 2
- Overlay H.265 Video with Transparency HOT 4
- option to change number of frames on export
- Sound gone when scaled video HOT 1
- Multiple timelines HOT 1
- black screen when the audio overlay goes to finish HOT 2
- transition demo not work HOT 1
- 如何知道轨道和片段之间的关系
- Is this framework support multiple layer blend mode? HOT 1
- Capture the current frame in composed player item HOT 1
- avplayer seek后,影音不同步 HOT 1
- Orientation problem: some videos are rotated by 90 or 180 degrees
- Example of merging several videos in sequence
- Example project doesn't work on Xcode 15 HOT 1
- 导出视频需要的时间太长
- how to support animation tools? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cabbage.