Giter VIP home page Giter VIP logo

Comments (6)

vienthuong avatar vienthuong commented on June 16, 2024

Hi my friend @ChristopherDosin
Could you describe more which part is not compatible with 8.1 :D Or you will make a PR?

from shopware-php-sdk.

ChristopherDosin avatar ChristopherDosin commented on June 16, 2024

Hello my friend @vienthuong :)

Currently the packages requires PHP 8.0 ->
https://github.com/vienthuong/shopware-php-sdk/blob/master/composer.json#L15

So this is basically blocking other packages that are requiring PHP 8.1

Not sure if we should just increase it to 8.1, or if we should update the whole code to PHP 8.1 and release a new version?

from shopware-php-sdk.

vienthuong avatar vienthuong commented on June 16, 2024

Ah sure, I think for "compatible" I think it's fine enough to add 8.* to the composer.json

from shopware-php-sdk.

ChristopherDosin avatar ChristopherDosin commented on June 16, 2024

Perfect. Should i do a PR or do you want to do it? ^^

from shopware-php-sdk.

vienthuong avatar vienthuong commented on June 16, 2024

a PR is welcomed :D otherwise I will do it tomorrow or sth, and we should increase the package minor version :)

from shopware-php-sdk.

vienthuong avatar vienthuong commented on June 16, 2024

I just released PHP 8.1 compatibility in 1.7.0 version, feel free to reopen ticket if you met any issue with it :)

from shopware-php-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.