Comments (6)
pabloelcolombiano
commented on May 29, 2024
Go for it!
from cakephp-fixture-factories.
jamisonbryant
commented on May 29, 2024
@pabloelcolombiano PRs up for both tickets I opened, thanks very much!
from cakephp-fixture-factories.
jamisonbryant
commented on May 29, 2024
@pabloelcolombiano Any feedback on the attached PR?
from cakephp-fixture-factories.
pabloelcolombiano
commented on May 29, 2024
@jamisonbryant thanks for the contribution indeed. I do not mind the non-BC aspect of it. This should however be documented in the docs. You will find my comments in the PR.
I do not mind also a PR to fix psalm, if you can/will, prior to this. If you do not have capacities, I will try to get this done during the coming days.
from cakephp-fixture-factories.
jamisonbryant
commented on May 29, 2024
Noted, thanks for the feedback. Regretfully I will not be able to address it for a week or two, as I am traveling out of the country with no access to my code.
If you are able to address the Psalm issue by the time I get back, I will make the changes requested and we should be able to get it merged in no time.
from cakephp-fixture-factories.
pabloelcolombiano
commented on May 29, 2024
Thanks a lot for this contribution. I will run a few additional tests and create a new tag.
from cakephp-fixture-factories.
Related Issues (20)
- How to nest ->with() HOT 2
- Recurrent PersistenceExceptions thrown in factories due to Primary Key collisions HOT 6
- Fix Psalm
- Composer require no DB cleaner
- Calling fixture factories for a table breaks application code that uses that table downstream HOT 4
- Primary key of type text should generate UUID HOT 1
- What is the mergeAssociated(array $data) function for? HOT 1
- Testing simple method without persisting data HOT 1
- fakerphp 8.2 warnings HOT 1
- Creating multiple translations using shadowStrategy HOT 1
- Truncate Dirty Tables Slowness HOT 2
- Feature Request: Add back-reference property to sub-entities HOT 5
- Error: Column "id" is an identity column defined as GENERATED ALWAYS HOT 1
- Feature Request: Ability to set nested values using `make` method HOT 2
- Enhance array notation
- Calling `with()` inside `setDefaultTemplate()` occurs unexpected increase of the associated entities HOT 4
- phpdoc @param types of `FactoryAwareTrait::getFactory()` is too narrower than acceptable types HOT 1
- Factory::make ignores null values
- Factory::make ignores null values HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cakephp-fixture-factories.