X-Frame-Options always set to deny about lookbook HOT 8 CLOSED

@louishuyng merged now :) Many thanks for your time on this, much appreciated.

from lookbook.

I will test it, I am pretty sure your proposal should fix it

from lookbook.

@louishuyng yes it does fix the issue

from lookbook.

Hey @louishuyng, many thanks for this. I think it definitely makes sense to normalize the strings to lower or uppercase before comparing them here.

Would you be happy to open a PR with your suggested change?

from lookbook.

@allmarkedup here is the PR for that: #554. I guess it just small changes there is enough for fixing this issue

from lookbook.

@louishuyng I am getting an error now when I upgraded to 2.20

from lookbook.

@adrienpoly could you help to contribute for that. I believe we just simply check nil for that before calling upcase method

headers["X-Frame-Options"]&.upcase == "DENY"

from lookbook.

I opened #561 to fix that

from lookbook.