HttpClient per request about mollieapi HOT 4 CLOSED

Hi gerbendv,

Perhaps we could add an constructor override to the API clients so you can inject your own HttpClient. Then you could use your dependency injection framework to pass a singleton instance of HttpClient.

Right now some of the API's have different authentication headers. The Mollie Connect API passes a clientid/clientsecret on every request, while most of the other API's pass the API key. If you'd pass in a singleton HttpClient I will need to make sure the correct information is passed in the Bearer token. This isn't very difficult, but I'll have to do some more testing before I implement this.

I'll also think about your suggestion to use a static HttpClient instead.

Kind regards,
Vincent

from mollieapi.

Hi Vincenttt,

I see the problem with the headers that would or would not be present on the HttpClient. A constructor override might be a good solution. I noticed that HttpClient has a overload of SendAsync in which an instance of HttpRequestMessage can be passed. That would enable you to add the right headers to the HttpRequestMessage.Headers collection.

Best regards,

Gerben

from mollieapi.

Hi gerbendv,

I just released a new version of the Mollie API (2.0.1.0) that allows you to pass your own HttpClient instance in the constructor of all the Mollie Client classes.

For example:

HttpClient myHttpClientInstance = new HttpClient();
PaymentClient paymentClient = new PaymentClient(this.ApiTestKey, myHttpClientInstance);
PaymentRequest paymentRequest = new PaymentRequest() {
    Amount = new Amount(Currency.EUR, "100.00"),
    Description = "Description",
    RedirectUrl = this.DefaultRedirectUrl
};
PaymentResponse result = await paymentClient.CreatePaymentAsync(paymentRequest);

Please let me know if you have any other suggestions/ideas.

Kind regards,
Vincent

from mollieapi.

Great, thanks!

from mollieapi.