Add connectionGet' that works like B.hGet about hs-connection HOT 6 CLOSED

I'ld rather see this as a pull request than as a comment. I'm OK in principle but got few comments:

• the name should be GetExact (other better name can be suggested). my assumption when I see Get' is that it is some strict variant of Get.

• no new imports needed in connection, specially Data.ByteString.Char8 is not needed (append exist in Data.ByteString)

• I'ld rather see the recursion as an inner loop than a toplevel loop, which would factor the conn:

  connectionGetExact conn = loop
  where loop x | x == 0 = return ..
  | otherwise = do
  ...
  loop

from hs-connection.

Thank you. I'll incorporate your recommendations and submit a Pull request in the next few days.

from hs-connection.

I just ran into a problem using connectionGet and found this issue. The proposed solution works perfectly for me. Are you still planning to add connectionGetExact to the library? As a temporary solution I added connectionGetExact to my project, but it seems like a nice function to have in the official API.

from hs-connection.

sorry about the crappy delay. This shoudn't have take that long, I just didn't see it.

from hs-connection.

@vincenthz this and the family of crypto libraries around it are essential. Creating and maintaining them is a huge service to me and to the rest of the Haskell community. Thank you 👍

from hs-connection.

I second that. Thanks!

from hs-connection.