Comments (2)
adiachenko
commented on August 16, 2024
@jcchavezs Sure, thanks for the reminder. I noticed from tests that tracer stopped propagating "x-b3-flags" header by default. Is that something that we should worry about?
From my understanding, this flags correlates to isDebug property on TraceContext although I am not too sure what it does or how to enable it since we don't directly manage this object.
from tracing-laravel.
jcchavezs
commented on August 16, 2024
I noticed from tests that tracer stopped propagating "x-b3-flags" header by default. Is that something that we should worry about?
Debug should only be propagated if it is 1 (see https://github.com/openzipkin/b3-propagation#debug-flag) and we tried to honor that in the test openzipkin/zipkin-php@091cc93#diff-71cf0cce040421feb2f4f628b86a03f9b0d8587b949820f9b506d31356aa2e47L258. What changed is that if x-b3-flags:1 we mark the context as sampled too (but when injecting the context we only pass the sampling flag if isDebug is false.
TL;DR from this library perspective we should not worry about it as propagation will handle it (unless you found a case).
from tracing-laravel.
Related Issues (15)
- Tracing db queries HOT 1
- Can't install on laravel 8 HOT 1
- How to got json detail for rootSpan after finish? HOT 2
- How to get spanMap as an array after span is finished? HOT 3
- 'Vinelab\Tracing\Contracts\Tracer' is not Instantiable HOT 2
- Too few arguments to function 'Illuminate\Support\Manager::createDriver()' HOT 5
- Lumen Support HOT 2
- Has anyone considered adding more events to Laravel? HOT 4
- Lumen with Vinelab/tracing-laravel plugin raised error HOT 1
- Drop support for some older versions of PHP and Laravel in the next major release HOT 7
- Why does `sampler` not support `PercentageSampler`
- 🐞 Bug - v2.3.2 - Invalid sampler class. Expected `BinarySampler` or `PercentageSampler`, got 0.000000 HOT 5
- Are we considering supporting `QueueReport`? HOT 2
- Consider using idiomatic zipkin tags HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tracing-laravel.