Giter VIP home page Giter VIP logo

Comments (6)

filipeximenes avatar filipeximenes commented on July 26, 2024

So something more customized than the default Django widget for groups and permissions, right?
Do you have some ideas on how this would look?

from django-role-permissions.

kavdev avatar kavdev commented on July 26, 2024

Exactly. The normal Django widget operates outside of the constraints (and get_or_create handiness) offered by django-role-permissions. I have no idea how to go about this yet or how it would look; it's something on my list to research.

Essentially, it would just need to have some way to call assign_role(), remove_role(), and clear_roles() with an input for the desired role.

from django-role-permissions.

gehaxelt avatar gehaxelt commented on July 26, 2024

Hi,
I just discovered this module and would love to see some kind of widget for the django admin backend, too.

Especially, because the permission names do not seem to get translated and/or displayed in the default permissions form:
permissions

That makes assigning the right permissions a bit hard ;)

Best

from django-role-permissions.

powderflask avatar powderflask commented on July 26, 2024

I have some code to potentially contribute that makes django-role-permissions play more nicely with the admin. In the spirit of the module, it simply piggybacks on the existing django user admin group selector.
It has 3 components:

  1. a UserAdminMixin class (utilized by an optional custom UserAdmin class) that overrides save_related() to update the user's roles to match the groups selected in the admin. In this way, changes made to the user's Groups via the admin are immediately reflected in the Roles.
  2. a management command, sync_roles, that can be run after changing the project's roles.py to create a Group for any new Roles (so the group is available via the admin), and re-assign roles to all users so any changes to the roles definitions are immediately reflected in user groups / permissions.
  3. default names for each permission -- as requested in #46 and #71 -- so the permission name appears in the admin.

I'm interested in contributing this code, but hoping for some feedback on whether these features are a sensible way to approach the problem -- they work for my use-case™, but I may be missing a bigger picture.

from django-role-permissions.

kavdev avatar kavdev commented on July 26, 2024

@powderflask

  1. sounds good! I'd suggest naming it RoleManagementMixin or something

  2. here's our approach:

from django.contrib.auth import get_user_model
from django.core.management.base import BaseCommand
from rolepermissions.roles import get_user_roles, clear_roles, assign_role


class Command(BaseCommand):

    help = "Sychronizes user Roles with the current available_permissions set in code."
    version = "1.0.0"

    def get_version(self):
        return self.version

    def handle(self, *args, **options):
        """For each user, grab their assigned roles, clear their roles, and then reassign them."""
        for user in get_user_model().objects.all():
            roles = get_user_roles(user=user)
            clear_roles(user=user)

            for role in roles:
                assign_role(user=user, role=role)
  1. solid

from django-role-permissions.

filipeximenes avatar filipeximenes commented on July 26, 2024

Hey, let's focus discussion on the PR (https://github.com/vintasoftware/django-role-permissions/pull/72/files) to avoid confusion :)

@kavdev I just made some comments in the PR, would appreciate your contribuitions there as well!

from django-role-permissions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.