Giter VIP home page Giter VIP logo

Comments (2)

hayakawa16 avatar hayakawa16 commented on June 12, 2024

While making corrections to MultiConcentricInclusionTissue GetDistanceToBoundary and writing unit tests, I decided to beef up
other unit tests for this class, in particular for GetRefractedDirection. I determined the Direction when refracting between n=1.0 and n=1.4 both ways. I used a flat layer plane to determine refracted Direction from test incident Directions. Then put the photon on top or bottom of cylinder with same incident Directions. Since on top or bottom, the plane determined from the surface normal will be flat like the layer and the direction of the normal will be outward like the layer. I used the validation values
from the layer tests for the cylinder tests.

From these unit tests I found that GetRefractedDirection algorithm was in error. I had previously used the reference: Bram de Greve "Reflections and Refractions in Ray Tracing" dated 11/13/2006. However after much trial and error, determined that the algorithm was missing something. The missing code was found in
https://stackoverflow.com/questions/26087106/refraction-in-raytracing
After applying this code my unit tests for the cylinder GetRefractedDirection passed.

If @janakarana feels these modifications solve the handling of air-(tissue cylinder layers of varying n)-air, I will start a PR.

from vts.

dcuccia avatar dcuccia commented on June 12, 2024

Awesome!

from vts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.