Giter VIP home page Giter VIP logo

Comments (8)

lmalenfant avatar lmalenfant commented on June 12, 2024 1

I put an upvote on this discussion, I probably should have made a comment also. If you would like to create a separate branch from master and make this change, we will be able to pull the Vts.Gui.Wpf into the solution to make sure the binding still works as expected.

from vts.

dcuccia avatar dcuccia commented on June 12, 2024 1

Cool, thanks Lisa! I'm on it. :)

from vts.

lmalenfant avatar lmalenfant commented on June 12, 2024

Cool, thanks Lisa! I'm on it. :)

Thank you!!

from vts.

lmalenfant avatar lmalenfant commented on June 12, 2024

There are multiple failing unit tests in the VTS, MCCL and PP (192), is it possible that this has affected the serialization/deserialization. When we make changes like this to the library we have to run unit tests before we create the PR. I think this code change needs investigating more.

from vts.

dcuccia avatar dcuccia commented on June 12, 2024

Ok, I'll take a look. Pretty sure this is a JSON.Net issue that I've fixed before. Sorry - was trying to get something out to you quickly yesterday.

from vts.

dcuccia avatar dcuccia commented on June 12, 2024

Pushed the small fix (this one gets me every time). Sorry for the churn - I'm used to pushing my changes to my remote branch and getting build/test automatically done for me, which blocks PR creation in the first place.

from vts.

dcuccia avatar dcuccia commented on June 12, 2024

(all tests passing now)

from vts.

lmalenfant avatar lmalenfant commented on June 12, 2024

Thanks! Let me review it on the branch first before recreating the PR.

from vts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.