Giter VIP home page Giter VIP logo

Comments (5)

rahmanramsi avatar rahmanramsi commented on June 21, 2024 1

yes it works. I will make PR for this issue

from jatsparserplugin.

Vitaliy-1 avatar Vitaliy-1 commented on June 21, 2024

Hi @rahmanramsi,

Please indicate the version of OJS and JATS Parser Plugin you are using.

from jatsparserplugin.

rahmanramsi avatar rahmanramsi commented on June 21, 2024

OJS Version : 3.3.0-7
JATS Parser Plugin Version : 2.1.9-3

from jatsparserplugin.

Vitaliy-1 avatar Vitaliy-1 commented on June 21, 2024

Looks like one of the dependent files of the submission file doesn't have genre. I don't think that this can happen under normal circumstances. You can find the list of genres in the genres table. I'm retrieving it here to identify if the dependent file is an image:

JATSParserPlugin/JatsParserPlugin.inc.php

Line 744 in 33945ec

$genre = $genreDao->getById($dependentFile->getData('genreId'));
. In your case it returns null on one of the files.
I'd check those dependent files first, I mean why they don't have genre assigned but for the plugin it's relatively easy do bypass by changing the line

JATSParserPlugin/JatsParserPlugin.inc.php

Line 745 in 33945ec

if ($genre->getCategory() !== GENRE_CATEGORY_ARTWORK) continue; // only art works are supported
to

if ($genre && $genre->getCategory() !== GENRE_CATEGORY_ARTWORK) continue; // only art works are supported.

If this works, I'd be appreciate for the PR.

from jatsparserplugin.

Vitaliy-1 avatar Vitaliy-1 commented on June 21, 2024

Thanks for confirming

from jatsparserplugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.