Giter VIP home page Giter VIP logo

Comments (3)

stackblitz avatar stackblitz commented on August 28, 2024

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

from vite.

hi-ogawa avatar hi-ogawa commented on August 28, 2024

Scenario 2 - write css.ligtningcss.target in Vite config

It should not have been necessary to write css.lightningcss.targets, because build.cssTarget was already set in Vite config!

This may be a gray area, but it's probably working as intended since built.cssTarget is a configuration for build.cssMinify. As in the documentation, css.lightningcss.targets should influence built.cssTarget when build.cssMinify: "lightningcss", but not the other way around.


Other than this, I think there is still an issue on lightningcss side. The error happens when Vite uses default targets from

targets:
options.lightningcss?.targets ??
convertTargets(ESBUILD_MODULES_TARGET),

export const ESBUILD_MODULES_TARGET = [
'es2020', // support import.meta.url
'edge88',
'firefox78',
'chrome87',
'safari14',
]

and this can be reproduced on their playground with safari14: lightningcss playground

from vite.

hi-ogawa avatar hi-ogawa commented on August 28, 2024

Whatever may happen, I am going to appreciate when the documentation becomes more clear about LightningCSS being incompatible to build.cssTarget today, with a note to redirect people to css.lightningcss.targets. It took me some time to discover this internal functioning when debugging.

@mrredtree I agree build.cssTarget is confusing now. Like you said, as a short term solution, it make sense to update the documentation and jsdoc. Please feel free to send a PR if you like.

from vite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.