Giter VIP home page Giter VIP logo

Comments (4)

keller-mark avatar keller-mark commented on July 20, 2024 1

If you dont mind I am going to split the grid issue into a separate issue

from vitessce-python.

sehilyi avatar sehilyi commented on July 20, 2024

In addition, the following code returns an error message.

vc.layout((umap | pca | cell_sets | genes) / heatmap);
Config validation failed
[
  {
    "keyword": "type",
    "dataPath": ".layout[0].w",
    "schemaPath": "#/definitions/components/items/properties/w/type",
    "params": {
      "type": "integer"
    },
    "message": "should be integer"
  }
]

I guess this is because the w value in react-grid-layout is accepting only integer values by a JSON schema, and adding many columns results the width less than 1.0. (1) I think the error message can be more understandable to users, or (2) allow double values (Although only the integer values are said to be officially allowed by react-grid-layout, I think double values work fine as well?).

from vitessce-python.

keller-mark avatar keller-mark commented on July 20, 2024

I think the first issue may be inherent to the magic syntax. Based on the way that operators are evaluated in python, I think (a | b | c) will always be evaluated as hconcat(hconcat(a, b), c) just like (1 + 2 + 3) would be ((1+2) + 3) as an abstract syntax tree.

But it is a good idea for us to write this in the documentation.

from vitessce-python.

sehilyi avatar sehilyi commented on July 20, 2024

Did not thought about the internal implementation of the magic syntax, but now it makes sense. It would be helpful if it is explained in the docs.

from vitessce-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.