Comments (1)
AriPerkkio
commented on May 28, 2024
1
The root cause is in line below. V8 provider is setting the executed filename as map.sources without checking whether original source map had any other sources set.
vitest/packages/coverage-v8/src/provider.ts
Line 333 in 6d1b145
Instead it should respect the original map.sources if it exists and resolve full path for that. With some quick testing the coverage looks much better. In the picture below the left side is current behavior and right one is with fixed sources. I added some uncovered if-branches to the original test code just to see that coverage reporting works after these changes:
from vitest.
Related Issues (20)
- Regression in v1.5.1: TypeError: Invalid value used as weak map key HOT 3
- Stack overflow caused by large output HOT 2
- 1.5.1 Throws Unhandled Rejections TypeErrors in coverage-instanbul - 1.4.0 works fine HOT 5
- `resolveId` is called before `buildStart` with enforce: 'pre' HOT 5
- 1.5.1 TypeError: WeakMap key null must be an object or an unregistered symbol HOT 1
- Object Properties are ignored in expect when there is a Symbol.iterator HOT 6
- vite-node should have different behavior with env vars than vite HOT 1
- TypeError: Cannot redefine property after upgrading to v1.5.0 HOT 2
- Function calls that doesn't match signatures result in test success HOT 4
- Exclude {test,spec}-d files from coverage by default HOT 4
- Docs: mocks cheatsheet hard to read
- Mocking dependencies of pnpm monorepo packages doesn't work as expected HOT 2
- Only setting `CI=1` prints the stdout HOT 4
- Document how to mock a class, an instance, a method in a class HOT 1
- Coverage of types files can end up with a fatal error: `Cannot read properties of undefined (reading 'endCol')` HOT 2
- Virtual modules in lib mode no longer work HOT 6
- vitest --ui fails to run on Windows 11 ARM64 HOT 2
- Add a reason parameter in expect HOT 1
- Mocking changes returned promises HOT 3
- Add "file" attribute to vitest JUnit reporter test case XML elements HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vitest.