Describe the bug 'jest-extended' lib seems to create duplicates in

jest-extended lib seems to create duplicates inside JUnit reporter about vitest HOT 3 CLOSED

andrii-nastenko commented on July 17, 2024

jest-extended lib seems to create duplicates inside JUnit reporter

from vitest.

Comments (3)

hi-ogawa commented on July 17, 2024

I think what appears duplicated is Error.message since JUnit output it to two places:

<failure message="...(here)...">
  ...(and here)...
  ...
</failure>

jest-extended's assertion error puts everything to single Error.message string, so probably that's what's happening. Vitest (originally chai?) assertion error has separate Error.message/actual/expected/diff fields, so this doesn't happen. Here is a quick repro:
https://stackblitz.com/edit/vitest-dev-vitest-7hsjhp?file=test%2Frepro.test.ts

junit.xml

<?xml version="1.0" encoding="UTF-8" ?>
<testsuites name="vitest tests" tests="3" failures="3" errors="0" time="3.535">
    <testsuite name="test/repro.test.ts" timestamp="2024-05-04T03:52:15.731Z" hostname="vitestdevvitest7hsjhp-btis" tests="3" failures="3" errors="0" skipped="0" time="0.018">
        <testcase classname="test/repro.test.ts" name="repro" time="0.009">
            <failure message="[2mexpect([22m[31mreceived[39m[2m).toIncludeMultiple([22m[32mexpected[39m[2m)[22m

Expected string to contain all substrings: 
  [32mArray [
  &quot;yo&quot;,
][39m
Received:
  [31m&quot;hey&quot;[39m" type="Error">
Error: expect(received).toIncludeMultiple(expected)

Expected string to contain all substrings: 
  Array [
  &quot;yo&quot;,
]
Received:
  &quot;hey&quot;
 ❯ eval test/repro.test.ts:7:17
            </failure>
        </testcase>
        <testcase classname="test/repro.test.ts" name="multiline message" time="0.002">
            <failure message="hello
world
goodbye" type="Error">
Error: hello
world
goodbye
 ❯ eval test/repro.test.ts:11:9
            </failure>
        </testcase>
        <testcase classname="test/repro.test.ts" name="native" time="0.005">
            <failure message="expected +0 to be 1 // Object.is equality" type="AssertionError">
AssertionError: expected +0 to be 1 // Object.is equality

- Expected
+ Received

- 1
+ 0

 ❯ eval test/repro.test.ts:15:13
            </failure>
        </testcase>
    </testsuite>
</testsuites>

Is there something inconvenient about this duplicate? I suppose it's all depend on how CI platform's UI renders it, so if you have any suggestions, please feel free to share.

Currently I see multiline string in <failure message="..."> attribute, so probably that one needs to be escaped.
(EDIT: ah maybe not, it looks like multiline attirbute is a legitimate thing)

from vitest.

andrii-nastenko commented on July 17, 2024

Hi. I thought that was somehow connected to console.logs / silent mode.

Anyway, it doesn't bother me as much.

Thank you for investigating this!

from vitest.

hi-ogawa commented on July 17, 2024

Okay, this seems fine for now, so closing.
Please feel free to report again if this causes concrete issues downstream.

from vitest.

Recommend Projects