Giter VIP home page Giter VIP logo

Comments (5)

sheremet-va avatar sheremet-va commented on August 16, 2024

We record the promise, so it's not required.

from vitest.

benmccann avatar benmccann commented on August 16, 2024

In that case the docs could be updated since they say "you need to use await": https://vitest.dev/api/expect.html#tomatchfilesnapshot

And if it's not required then perhaps it could just be synchronous to avoid the confusion?

from vitest.

sheremet-va avatar sheremet-va commented on August 16, 2024

It does return a Promise, so I don't know what else to tell you. It cannot be sync because to read a file in the browser we need to make an async request. In node.js it could technically be sync, but then the API would differ which is undesirable.

from vitest.

benmccann avatar benmccann commented on August 16, 2024

We could probably just clarify the docs about the difference between awaiting and not awaiting it

from vitest.

sheremet-va avatar sheremet-va commented on August 16, 2024

If it's not awaited, then the next line will be executed even if the snapshot fail which might not be expected behaviour but it at least correctly fails the test.

from vitest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.