Comments (1)
Hello @VitorGuedesMadeira , @for-ashraf and @diegoyon 👋 ,
I am Nemwel your reviewer for this PR 🧔♂️
Thank you for meeting all the project requirements good job! 🥳
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🥳 🎉
Highlights
Great job setting up the correct linters ✔️
Professional documentation ✔️
Correct workflow ✔️
Meaningful commit messages ✔️
Met all the milestone requirements ✔️
[Optional] suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from capstone-ruby.
Related Issues (20)
- [2pt] Create Item class in a .rb file (GROUP TASK)
- [1pt] All data should be preserved by saving collections in .json files. (MEMBER #1)
- [2pt] Add unit tests for all implemented methods (MEMBER #1)
- [2pt] Create a schema.sql file with tables that will be analogical to the structure of the classes that you created (MEMBER #1)
- [3pt] Create a MusicAlbum class (MEMBER #2)
- [3pt] Create a Genre class with an association to the Item class (in a separate .rb file). (MEMBER #2)
- [2pt] Add unit tests for all implemented methods (MEMBER #2)
- [1pt] All data should be preserved by saving collections in .json files. (MEMBER #2)
- [2pt] Create a schema.sql file with tables that will be analogical to the structure of the classes that you created (MEMBER #2)
- [3pt] Create Source class with an association to the Item class (MEMBER #4)
- [3pt] Create Movie class (MEMBER #4)
- [2pt] Create a schema.sql file with tables that will be analogical to the structure of the classes that you created (MEMBER #3)
- [1pt] All data should be preserved by saving collections in .json files.(MEMBER #3)
- [2pt] Add unit tests for all implemented methods. (MEMBER #3)
- [3pt] Create an Author class with an association to the Item class (MEMBER #3)
- [3pt] Create a Game class (MEMBER #3)
- [1pt] All data should be preserved by saving collections in .json files.(MEMBER #4))
- [2pt] Add unit tests for all implemented methods. (MEMBER #4))
- [2pt] Create a schema.sql file with tables that will be analogical to the structure of the classes that you created. (MEMBER #4))
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from capstone-ruby.