[Question] [Performance] Concatenate and minify JavaScript dependencies? about hugo-theme-docdock HOT 4 CLOSED

Hi @vjeantet,

What's the best way to apply those optimizations just for my documentation site? I don't like the idea of overriding footer.html (copying the file from themes\hugo-theme-docdock\layouts\partials) because it contains more than the script.

Would it be a good idea to split the scripts fromfooter.html and move them into its own file like scripts.html? That way, anyone can easily override the included scripts?

What's your take on this?

Cheers

from hugo-theme-docdock.

Not sure such optimization is really needed. With http/2 concatenation leads to worse performance due to cache invalidation, when one script changes. All scripts are loaded with almost no overhead due to http/2.

Minification could still be something interesting. This can easily be done via a PR I assume.

For overwriting specific scripts and where they are loaded from. As far as best practice goes:

• load them locally first
• make it configurable via file or setting to load from somewhere else.

from hugo-theme-docdock.

Thanks for getting back to me @stp-ip. Unfortunately, not everyone is using http/2 which means it would be good to concatenate / minify those assets.

But instead of doing the optimizations for everyone (which could be counter productive for those using http/2, as you pointed out), I will submit a PR to move the scripts to their own partial file. That way, we increase flexibility for developers.

from hugo-theme-docdock.

FYI The #53 has been merged, allowing more flexibility for developers

from hugo-theme-docdock.