Footer partial generator extreme amount of whitespace about hugo-theme-docdock HOT 13 CLOSED

By removing that part from the footer, site generation goes from 48 => 24 seconds. Files also get half the size.

from hugo-theme-docdock.

I see Hugo has wonderful builtin function which could be as wide improvement to minify rendered HTML across all themes. No external build tools then required.

https://gohugo.io/templates/introduction/#whitespace

from hugo-theme-docdock.

@GeertvanHorrik can you try this e371ac0?

from hugo-theme-docdock.

Doesn't seem to work. It's the spaces in front of the code that are the culprit:

from hugo-theme-docdock.

Yes, those spaces I "compressed". I did changes only inside <div id="navigation">..</div>. So many spaces should come from one of loops (range).

1. You sure my commit is in effect for local copy you try?
2. Maybe you have this file override outside theme directory?
3. Restart Hugo, live-preview can fail update template files (if you use live-preview).
4. Look for errors when starting local Hugo server.
   and...
5. Can you locate from where exactly in .html layout those extra whitespaces come from?

from hugo-theme-docdock.

Using this seems to fix it:

<div id="navigation">
<!-- Next prev page -->
{{with ($.Scratch.Get "prevPage")}}<a class="nav nav-prev" href="{{.URL}}" title="{{.Title}}"> <i class="fa fa-chevron-left"></i></a>{{end}}
{{with ($.Scratch.Get "nextPage")}}<a class="nav nav-next" href="{{.URL}}" title="{{.Title}}" style="margin-right: 0px;"><i class="fa fa-chevron-right"></i></a>{{end}}
</div>

from hugo-theme-docdock.

@GeertvanHorrik please check-out this compress-html-whitespace and check result

from hugo-theme-docdock.

I think it's the spaces in front of the template codes that are the issue. Your fixes don't seem to fully solve the issue:

from hugo-theme-docdock.

After some more tests, it already looks a lot cleaner and files have gone from 700kb => 360kb.

from hugo-theme-docdock.

As a final experiment, I've opened the menu.html partial in notepad++, select all, shift + tab until there is no more indentation. Now the file is 320kb, which is a lot better.

from hugo-theme-docdock.

Those blank lines in #61 (comment) are from template lines, which has Hugo template code, but does not produce any actual output.

Removing whitespace before <a> tag would only remove from that line. It can't produce that amount of blank lines, and also have different indentation. Here all lines <li>, <a ... and </li> have same indent space.

Removing all, all, all odd spaces (minifying it) in template is not practical as it makes code and HTML hard to read. To do that for production level use tools for this purpose. I.e. something automated like Grunt or even SaaS like Netlify.

from hugo-theme-docdock.

@GeertvanHorrik I suggest this to be closed.

from hugo-theme-docdock.

Fully agree, thanks for fixing!

from hugo-theme-docdock.