ContextMenu onShow() / onHide() callbacks about react-contextmenu HOT 8 CLOSED

This is a good idea. I'll keep this in mind for next release

from react-contextmenu.

I've released v2.0.0-alpha.1 with this feature. Do check it out. Any feedback is welcome 😃

from react-contextmenu.

@vkbansal , is my current code supposed to work if i update to 2.x ? I see a render warning, even if i try to use the SimpleMenu example code as is.

warning.js?8a56:44Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components).

from react-contextmenu.

Not out of the box but check the changes:
https://github.com/vkbansal/react-contextmenu/releases/tag/v2.0.0-alpha.1

And updated Readme:
https://github.com/vkbansal/react-contextmenu/blob/v2/README.md

from react-contextmenu.

@vkbansal , reading now. The example i linked though still uses ContextMenuLayer so it probably needs fixing. They probably need some update because usage is not very clear at the moment.

UPDATE: The updated readme was more clear and I am not testing the onClick functionality. I will report back.

from react-contextmenu.

The example i linked though still uses ContextMenuLayer

Fixed it. I was too lazy to update the component name. It should not be confusing now.

from react-contextmenu.

@vkbansal , cool. I also used onShow and it seems to be working normally. I haven't found any problems at the moment so you can probably close this issue.

from react-contextmenu.

Cool

from react-contextmenu.