Giter VIP home page Giter VIP logo

Comments (4)

VladimirMarkelov avatar VladimirMarkelov commented on June 9, 2024

Hi,
thank you for the idea.

if set_fg(None) works as expected everywhere(I have not tried), it is a good thing to implement. Though, having a default_color in config also makes sense. We can do this way: by default the configuration does not have default_color set(the line is in section colors but the line is commented out). The config reader defaults it to None. In this case we have both: good default for everyone and it is configurable.

from ttdl.

VladimirMarkelov avatar VladimirMarkelov commented on June 9, 2024

I added a default color to configuration. By default, the default foreground color is None, not White.

  • If you can, please try my current working branch https://github.com/VladimirMarkelov/ttdl/tree/def-clr-none . If it works for you fine, I'll merge this into master and issue a new release. If it doesn't, please try to fix at your side and open an MR for this branch
  • if you cannot, I'll merge the branch as is(it works well for me and my terminal with default theme) and issue a new release

from ttdl.

alexdavid avatar alexdavid commented on June 9, 2024

Ah sorry I missed your messages. Yes this works great as it uses the default theme's fg color. Thanks for the implementation and quick turn around!

from ttdl.

VladimirMarkelov avatar VladimirMarkelov commented on June 9, 2024

Ah sorry I missed your messages. Yes this works great as it uses the default theme's fg color. Thanks for the implementation and quick turn around!

You're welcome!

from ttdl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.