Giter VIP home page Giter VIP logo

Comments (4)

spytheman avatar spytheman commented on August 21, 2024 2

One problem that will have to be solved too, when the first variant type of a sumtype declaration, gets used to define the default value, is that currently v fmt -w . will reorder the sumtype variants in alphabetical order, and it should not, since the first type will have a semantic meaning in the future.

from v.

spytheman avatar spytheman commented on August 21, 2024

The same is true for interface values too - they also do not have default values.

For them, the problem is mitigated a bit because we do have an error for some situations involving them:

a.v:2:6: error: cannot instantiate interface `Abc`
    1 | interface Abc{}
    2 | a := Abc{}
      |      ~~~~~
    3 | dump(a)
#1 20:03:14 ^ master /v/oo>

but others are still allowed:

a.v:2:6: warning: arrays of interfaces need to be initialized right away, therefore `len:` cannot be used (unless inside `unsafe`, or if you also use `init:`)
    1 | interface Abc{}
    2 | a := []Abc{len:4}
      |      ~~~~~~
    3 | dump(a)
[a.v:3] a: [unknown interface value, unknown interface value, unknown interface value, unknown interface value]

and even runtime errors, with no complains from the compiler:

interface Abc{}
struct MyStruct { i Abc }
a := []MyStruct{len:4}
dump(a)

producing:

#148 20:05:19 ^ master /v/oo>v run a.v
/tmp/v_1000/a.01J516DMX1F1X3GBBFX1R951GE.tmp.c:2277: at indent_main__Abc_str: RUNTIME ERROR: invalid memory access
/tmp/v_1000/a.01J516DMX1F1X3GBBFX1R951GE.tmp.c:2264: by indent_main__MyStruct_str
/tmp/v_1000/a.01J516DMX1F1X3GBBFX1R951GE.tmp.c:2216: by indent_Array_main__MyStruct_str
/tmp/v_1000/a.01J516DMX1F1X3GBBFX1R951GE.tmp.c:2210: by Array_main__MyStruct_str
/tmp/v_1000/a.01J516DMX1F1X3GBBFX1R951GE.tmp.c:2233: by _v_dump_expr_Array_main__MyStruct
/tmp/v_1000/a.01J516DMX1F1X3GBBFX1R951GE.tmp.c:13400: by main__main

from v.

JalonSolov avatar JalonSolov commented on August 21, 2024

It could always alphabetize all the types after the first, but that seems like more trouble than it's worth.

Changing the defaults for interfaces may also need it's own separate issue... seems like a much bigger problem than sum types.

from v.

medvednikov avatar medvednikov commented on August 21, 2024

Just wanted to confirm that agree with this notion.

from v.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.