Giter VIP home page Giter VIP logo

Comments (10)

ratkosrb avatar ratkosrb commented on September 26, 2024

I disagree with this. Chest type gameobjects have a data field for consumable and for loot restock time. This data is from sniffs. We are not going to change the sniff data to make the loot restock instantly.

from core.

ShiyoKozuki avatar ShiyoKozuki commented on September 26, 2024

I disagree with this. Chest type gameobjects have a data field for consumable and for loot restock time. This data is from sniffs. We are not going to change the sniff data to make the loot restock instantly.

They restock in 30 seconds, like every other quest on vmangos that is 1 time loot for a single item.
The issue is their object does not despawn, and they are still clickable without loot. This is not how anything else on Vmangos behaves
Other objects respawn loot in 30 seconds, but also despawn during that time, or simply do not despawn and always have loot.

These were recently changed from 5 minute respawn to 30 seconds as a bugfix, and that person(tyler or something) for other quests like this, but those already had the object despawn.
These simply did not have the object despawn, and he accidentally missed them. They are bugged.

You aren't changing anything from Classic sniffs, they are bugged in comparison to the other code on vmangos.

from core.

ratkosrb avatar ratkosrb commented on September 26, 2024

Why would they be marked as non consumable and have restock time set in the gameobject template if they are meant to despawn? Respawn time is completely different thing, that is set per spawn in the gameobject table, not in the template table. Whether gobject is consumable and the loot restock time is in the gameobject template table which is sniffed.

from core.

ShiyoKozuki avatar ShiyoKozuki commented on September 26, 2024

Why would they be marked as non consumable and have restock time set in the gameobject template if they are meant to despawn? Respawn time is completely different thing, that is set per spawn in the gameobject table, not in the template table. Whether gobject is consumable and the loot restock time is in the gameobject template table which is sniffed.

On retail they don't despawn, but insta restock.
On vmangos they don't despawn, but also don't restock.
That is why I gave two options - either despawn for 30 seconds, or are immediately stocked with loot.
if you want accurate, it's immediate restock and no despawn.
These are the only two remaining quests I've experienced so far that have this strange "invisible loot" issue.
I lvled on classic duo, and never ran into this issue.

from core.

ratkosrb avatar ratkosrb commented on September 26, 2024

If its supposed to be immediate why isn't the restock time in the gameobject template 0 or 1, but 30 seconds instead?

from core.

ShiyoKozuki avatar ShiyoKozuki commented on September 26, 2024

If its supposed to be immediate why isn't the restock time in the gameobject template 0 or 1, but 30 seconds instead?

I don't know, I'm not a reverse engineer, only a player.

The 30 second respawn is tolerable(5 minutes was awful..), but it seems buggy and nothing else works like it. if it's meant to be, then it's meant to be.

I leveled on Turtle WoW and these quests were like this.
I leveled on classic era duo immediately afterwards, and never ran into this issue. The quests did not have this issue.
We specifically noted these quests behaving completely different on classic era, because waiting around 5m on multiple quests was really unfun.

This has been bugged on emulators for years.

from core.

ratkosrb avatar ratkosrb commented on September 26, 2024

Do not mention private servers as examples, we are not emulating a private server. Nor should you argue your point by mentioning how fun or unfun something is, that is completely irrelevant, player satisfaction does not matter to the goals of the project.

Regarding your claim that it is restocked instantly on classic (for which you provided no proof), it is possible that this is a quality of life change they made for classic to reduce bottlenecks just like layering. The restock time is clearly not instant in the original data. If it is restocking instantly like you claim then they must be overriding the db values from the core. I require a video from original vanilla that clearly demonstrates the gameobject in question works the way you claim. Either it should disappear and despawn after being looted in the video, or it gets successfully looted twice (loot it, destroy quest item, loot it again).

from core.

ShiyoKozuki avatar ShiyoKozuki commented on September 26, 2024

I mentioned Turtle WOW because it was 5m respawn there, which is based off a much older version of mangos(I think?) to use as an example that it's been bugged for years on emulators. It worked the same way there as it does here, years later. It's only until recently (my recent bug report) that it was fixed on emulators to be 30 seconds. Nowhere did I state that turtle wow is accurate and you should be replicating a private server, I actually stated the opposite.

I don't have access to a classic account without paying Blizzard $15, and I don't see how an object despawning is QOL?
It still seems weird for something to exist as an object but have no loot, when the majority of objects on this project, do not behave like that, which is why I reported it as a bug, since it seems wrong and out of place.

I didn't report this because I wanted QOL, or change, or edited. I reported this because, as I stated, other objects in this project do not behave the same. You have to wait 30 seconds regardless of if this is changed or not. There is no gameplay benefit from my proposed changes, only consistency.

from core.

ShiyoKozuki avatar ShiyoKozuki commented on September 26, 2024

It's 30s respawn on loot RIGHT NOW on vmangos
if you make the object despawn for 30s, its still 30s to loot, but the object isn't clickable with blank "no loot".
That can't possibly be classic QOL because you still have to wait 30s...
There is zero beneficial gameplay impact to anything being suggested.
My proposed change makes it seem less buggy, because right now, it seems buggy as it doesn't behave like other objects in the game.

from core.

ratkosrb avatar ratkosrb commented on September 26, 2024

Nothing will be done without proof from vanilla. The data says 30 seconds.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.